-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Span.h to a source_set that tracks its dependencies. #29491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
September 28, 2023 15:56
bzbarsky-apple
force-pushed
the
span-deps
branch
from
October 12, 2023 00:34
e9915b4
to
7e30c5b
Compare
github-actions
bot
added
tools
examples
esp32
linux
zephyr
tizen
For Tizen platform
silabs
labels
Oct 12, 2023
PR #29491: Size comparison from 2a37b68 to 7e30c5b Increases (1 build for cc32xx)
Decreases (2 builds for cc32xx, mbed)
Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
force-pushed
the
span-deps
branch
from
October 12, 2023 01:55
7e30c5b
to
98c9c7d
Compare
PR #29491: Size comparison from 9555e32 to 98c9c7d Increases (9 builds for cc13x4_26x4, cc32xx, k32w)
Decreases (4 builds for cc32xx, k32w, mbed, qpg)
Full report (16 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, qpg)
|
bzbarsky-apple
force-pushed
the
span-deps
branch
from
October 12, 2023 03:00
98c9c7d
to
6a29631
Compare
PR #29491: Size comparison from 9555e32 to 6a29631 Increases (13 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, psoc6)
Decreases (15 builds for bl702, bl702l, cc32xx, k32w, mbed, psoc6, qpg)
Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
bzbarsky-apple
force-pushed
the
span-deps
branch
from
October 12, 2023 04:07
6a29631
to
74dc8e8
Compare
PR #29491: Size comparison from 9555e32 to 74dc8e8 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
This requires that those dependencies be separate things that are not the entire "support" library, because some things need Span but can't depend on all of "support". Fixes project-chip#29490
bzbarsky-apple
force-pushed
the
span-deps
branch
from
October 12, 2023 04:19
74dc8e8
to
2e61d80
Compare
PR #29491: Size comparison from 9555e32 to 2e61d80 Increases (18 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, psoc6)
Decreases (25 builds for bl702, bl702l, cc32xx, efr32, k32w, linux, mbed, psoc6, qpg, telink)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 12, 2023
arkq
approved these changes
Oct 13, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…p#29491) This requires that those dependencies be separate things that are not the entire "support" library, because some things need Span but can't depend on all of "support". Fixes project-chip#29490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires that those dependencies be separate things that are not the entire "support" library, because some things need Span but can't depend on all of "support". Maybe these should just all be lumped into "support_core"... but then why are these things in support/ and not core/ (which are very much "these are the same thing, but we are going to pretend the are not).
Fixes #29490