-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fixed LCD animations for window-app #29675
[Silabs] Fixed LCD animations for window-app #29675
Conversation
PR #29675: Size comparison from 555eed5 to e6b445a Increases (1 build for efr32)
Decreases (2 builds for bl702, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29675: Size comparison from ffd1571 to 3c1d13b Increases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to prevent accidental merge..
PR #29675: Size comparison from ffd1571 to 3aae240 Increases (37 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, psoc6)
Decreases (34 builds for bl702, bl702l, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
3aae240
to
014bfd3
Compare
PR #29675: Size comparison from 7c4956e to 014bfd3 Increases (1 build for bl602)
Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29675: Size comparison from e6f0134 to afb097e Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #29675: Size comparison from e6f0134 to 8ee4f20 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29675: Size comparison from e6f0134 to 162d65b Increases (4 builds for efr32)
Decreases (1 build for efr32)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
* Fixed LCD animations for window-app * Modified type conversion from (uint8_t *) to Uint8::from_char as mentioned in comments * As per comments, using BaseApplication to get provision state and updated UpdateLEDs() API. * Added sIsProvisioned as member variable in BaseApplication class. * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Issue : LCD animations are not working for window-app.
Fix : The variable 'mState.isWiFiProvisioned' is not being modified after commissioning, so the LCD 'paint' API was not being called. Replaced the variable with respective API call to get the commissioning status.
After factory reset, QR code is also being displayed on LCD.
Notes : For LCD to work on thread applications, the variable 'mState.isThreadProvisioned' must be set to 1 after commissioning. We were unable to verify this as we do not have the thread setup.