-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Matter Media: Resolve items from Issue 30807 #31108
Conversation
PR #31108: Size comparison from ab11309 to 31907d0 Increases (4 builds for esp32, linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
31907d0
to
88c5e1b
Compare
PR #31108: Size comparison from ce32d11 to 88c5e1b Increases (3 builds for linux)
Decreases (5 builds for efr32, esp32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Added label |
88c5e1b
to
808f377
Compare
PR #31108: Size comparison from 19e202e to 808f377 Increases (1 build for linux)
Decreases (2 builds for efr32, esp32)
Full report (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Why are they not labeled provisional in the XML? |
808f377
to
c89dfcd
Compare
PR #31108: Size comparison from b22a396 to c89dfcd Increases (3 builds for linux)
Decreases (5 builds for efr32, esp32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I'm not familiar with the process. Just to confirm it's necessary to add provisional label in the xml for cluster changes that still haven't been released? It does make however sense to add labels in case xml that was released in previous matter versions is changed, the other way round is not that obvious. Edit: I've added provisional label, rebuilt the zap files, but CI task still fails |
c89dfcd
to
09eab13
Compare
PR #31108: Size comparison from b22a396 to 09eab13 Increases (3 builds for linux)
Decreases (5 builds for efr32, esp32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Add provisional labels Updated ContentAppObserver to pass test cases
09eab13
to
d30d2f2
Compare
PR #31108: Size comparison from 3e8aeeb to d30d2f2 Increases (3 builds for linux)
Decreases (5 builds for efr32, esp32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The TV & TV Cluster App & Media Clusters have reported issues per link.
Problem
#2. tv-app: add content app observer as a client cluster on ep3. Remove all content app observer server cluster entries from tv-app.
#3. tv-app: add binding as a server cluster on ep3.
#5. tv-casting-app: add content app observer as a server cluster on ep1.
#6. tv-casting-app: add content control as a client cluster on ep1.
#8. remove unused method GetNodeId (https://github.com/project-chip/connectedhomeip/pull/30691/files#diff-af42e90894a9e71673d408eaf26d5c2997324dda04b9f7b3ab8587cfe98c76feR55)
#9. channel cluster xml: fix Paging field on ProgramGuideResponse - should be a ChannelPagingStruct.
#11. content app observer cluster xml: ContentAppMessageResponse has optional property swapped on 3 fields. The status should be mandatory and the others optional.
#12. Go through media clusters and convert type="ARRAY" to type="array"
Change overview
Tests
Build the TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/
Built the CHIP tool test client using command:
scripts/examples/gn_build_example.sh examples/chip-tool out/debug/ chip_config_network_layer_ble=false
Run tests using command:
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --runner chip_tool_python \ --chip-tool ./out/debug/chip-tool \ run \ --iterations 1 \ --test-timeout-seconds 120 \ --tv-app ./out/debug/chip-tv-app \ "