Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SystemClock, SystemMutex, and SystemError #11

Merged
merged 12 commits into from
Mar 8, 2020
Merged

Add SystemClock, SystemMutex, and SystemError #11

merged 12 commits into from
Mar 8, 2020

Conversation

sagar-apple
Copy link
Contributor

@sagar-apple sagar-apple commented Mar 4, 2020 •
edited
Loading

Added the first little bits for system as libSystemLayer.

Should help lay the foundation for more system components and other dependencies.

  • Add SystemMutex and SystemError
  • Add SystemClock to libSystemLayer.a
  • Add a sanity unit test for SystemMutex and SystemClock

Note this PR contains a pre-generated BuildConfig file since we do not currently have a way to autogen these. It will have to be swapped out at some later date.

@woody-apple
Copy link
Contributor

@hawk248 @chrisdecenzo We need an review + approval from one more company. Any chance you folks could help out?

@sagar-apple sagar-apple changed the title Add SystemMutex and SystemError Add SystemClock, SystemMutex, and SystemError Mar 6, 2020
robszewczyk
robszewczyk requested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@robszewczyk robszewczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per earlier discussion: copyright should be accumulative. It does not seem quite right to just drop in <COPYRIGHT>

src/system/tests/tests.cpp Outdated Show resolved Hide resolved
hawk248
hawk248 approved these changes Mar 8, 2020
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@woody-apple woody-apple merged commit 51abf93 into project-chip:master Mar 8, 2020
@woody-apple
Copy link
Contributor

Thanks! Merging based on 3 approvals.

@sagar-apple sagar-apple deleted the bring_system branch March 9, 2020 16:43
@cjandhyala cjandhyala mentioned this pull request Oct 30, 2020
Closed
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Sep 12, 2022
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#11: Optimize build time with parrallel node
a865870 
Merge in WMN_TOOLS/matter from optimize_ci_build_time to silabs

Squashed commit of the following:

commit 7ec0d686f99aac591c24a7a1492cd9238979a758
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Tue Jul 12 10:06:57 2022 -0400

    Optimize build time with parrallel node
@turon turon mentioned this pull request Sep 24, 2022
Closed
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#11: Optimize build time with parrallel node
9de6cee 
Merge in WMN_TOOLS/matter from optimize_ci_build_time to silabs

Squashed commit of the following:

commit 7ec0d686f99aac591c24a7a1492cd9238979a758
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Tue Jul 12 10:06:57 2022 -0400

    Optimize build time with parrallel node
@jagadeesh-ayla jagadeesh-ayla mentioned this pull request Feb 14, 2023
Closed
@yzm157 yzm157 mentioned this pull request Mar 22, 2023
Merged
@mukulag8293 mukulag8293 mentioned this pull request Apr 13, 2023
Open
@yunhanw-google yunhanw-google mentioned this pull request Jul 28, 2023
Open
This was referenced Aug 1, 2023
Closed
Closed
@netscell netscell mentioned this pull request Sep 5, 2023
Closed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#11: Optimize build time with parrallel node
91dc2ae 
Merge in WMN_TOOLS/matter from optimize_ci_build_time to silabs

Squashed commit of the following:

commit 7ec0d686f99aac591c24a7a1492cd9238979a758
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Tue Jul 12 10:06:57 2022 -0400

    Optimize build time with parrallel node
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@bzbarsky-apple
Fix intermittent LSan failures running "darwin-framework-tool tests l…
b846dbe 
…ist". (#29666)

The typical failure there looks like this:

==29620==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12)
    #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789)
    #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db)
    #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa)
    #4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8)
    #5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1)
    #6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44)
    #7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343)
    #8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992)
    #9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7)
    #10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894)
    #11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e)
    #12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac)
    #13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25)
    #14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2)
    #15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6)
    #16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603)
    #17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81)
    #18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659)
    #19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d)
    #20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c)
    #21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@bzbarsky-apple @HunsupJung
Fix intermittent LSan failures running "darwin-framework-tool tests l…
d10570d 
…ist". (project-chip#29666)

The typical failure there looks like this:

==29620==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12)
    #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789)
    #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db)
    project-chip#3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa)
    project-chip#4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8)
    project-chip#5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1)
    project-chip#6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44)
    project-chip#7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343)
    project-chip#8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992)
    project-chip#9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7)
    project-chip#10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894)
    project-chip#11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e)
    project-chip#12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac)
    project-chip#13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25)
    project-chip#14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2)
    project-chip#15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6)
    project-chip#16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603)
    project-chip#17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81)
    project-chip#18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659)
    project-chip#19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d)
    project-chip#20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c)
    project-chip#21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
@M201370367 M201370367 mentioned this pull request Oct 25, 2023
Open
@yunhanw-google yunhanw-google mentioned this pull request Dec 12, 2023
Open
@joonhaengHeo joonhaengHeo mentioned this pull request Dec 20, 2023
Closed
@lazarkov lazarkov mentioned this pull request Dec 20, 2023
Merged
@pgatti86 pgatti86 mentioned this pull request Dec 22, 2023
Closed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#11: Optimize build time with parrallel node
5a4554e 
Merge in WMN_TOOLS/matter from optimize_ci_build_time to silabs

Squashed commit of the following:

commit 7ec0d686f99aac591c24a7a1492cd9238979a758
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Tue Jul 12 10:06:57 2022 -0400

    Optimize build time with parrallel node
@yunhanw-google yunhanw-google mentioned this pull request Feb 1, 2024
Merged
@salvio96 salvio96 mentioned this pull request Feb 21, 2024
Closed
@JasonClark2 JasonClark2 mentioned this pull request Apr 3, 2024
Open
@mhwang408 mhwang408 mentioned this pull request Jun 27, 2024
Closed
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#11: Optimize build time with parrallel node
5dd1584 
Merge in WMN_TOOLS/matter from optimize_ci_build_time to silabs

Squashed commit of the following:

commit 7ec0d686f99aac591c24a7a1492cd9238979a758
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Tue Jul 12 10:06:57 2022 -0400

    Optimize build time with parrallel node
@Alami-Amine Alami-Amine mentioned this pull request Sep 3, 2024
Open
1 task
lpbeliveau-silabs added a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Sep 23, 2024
@lpbeliveau-silabs
Pull request project-chip#11: Provisioning series 3
47557c5 
Merge in WMN_TOOLS/matter_sdk from feature/provisioning_api_series3 to feature/rainier-ifc2

Squashed commit of the following:

commit 0f219b792349f77756e33fe820fdb549376bb146
Author: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
Date:   Tue Sep 10 14:14:52 2024 -0400

    Added series 3 API to replace MSC and updated to support series3 flash api
lpbeliveau-silabs added a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Sep 23, 2024
@lpbeliveau-silabs
Pull request project-chip#11: Provisioning series 3
f89ece6 
Merge in WMN_TOOLS/matter_sdk from feature/provisioning_api_series3 to feature/rainier-ifc2

Squashed commit of the following:

commit 0f219b792349f77756e33fe820fdb549376bb146
Author: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
Date:   Tue Sep 10 14:14:52 2024 -0400

    Added series 3 API to replace MSC and updated to support series3 flash api
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@lpbeliveau-silabs
Pull request #11: Provisioning series 3 (#35733)
b6daecb 
Merge in WMN_TOOLS/matter_sdk from feature/provisioning_api_series3 to feature/rainier-ifc2

Squashed commit of the following:

commit 0f219b792349f77756e33fe820fdb549376bb146
Author: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
Date:   Tue Sep 10 14:14:52 2024 -0400

    Added series 3 API to replace MSC and updated to support series3 flash api
@skyFzz skyFzz mentioned this pull request Sep 24, 2024
Closed
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@lpbeliveau-silabs @yyzhong-g
Pull request project-chip#11: Provisioning series 3 (project-chip#35733)
dca80fc 
Merge in WMN_TOOLS/matter_sdk from feature/provisioning_api_series3 to feature/rainier-ifc2

Squashed commit of the following:

commit 0f219b792349f77756e33fe820fdb549376bb146
Author: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
Date:   Tue Sep 10 14:14:52 2024 -0400

    Added series 3 API to replace MSC and updated to support series3 flash api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-apple pan-apple pan-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@hawk248 hawk248 hawk248 approved these changes

@robszewczyk robszewczyk robszewczyk approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sagar-apple @woody-apple @gerickson @robszewczyk @hawk248 @pan-apple