-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing company for Chris #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anush-apple
approved these changes
Mar 4, 2020
robszewczyk
requested review from
robszewczyk,
chrisdecenzo,
clapre,
gerickson and
hawk248
March 4, 2020 17:38
robszewczyk
approved these changes
Mar 4, 2020
gerickson
approved these changes
Mar 4, 2020
Pending @hawk248 @chrisdecenzo review |
hawk248
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Thanks you, has approval from 3 companies. Merging. |
restyled-io bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
Update RotatingId backup#1 from master
Merged
ghost
mentioned this pull request
Nov 22, 2021
tcv-geo
pushed a commit
to tcv-geo/connectedhomeip
that referenced
this pull request
Mar 30, 2022
…tring_fix Fix K32W0Config string handling on write, some cosmetic updates, update to not call same functions twice
jculbert
pushed a commit
to jculbert/connectedhomeip
that referenced
this pull request
Jan 10, 2023
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 30fd4a1e5232497a98ba2048af53e574f3e20b4c Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jul 6 14:42:12 2022 -0400 🛠 Rebase Fix. commit 83b558f3d8e64817d22feefe0051631f09bb6aaa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jun 2 16:19:34 2022 -0400 ✨ Edit comment format. commit 468db8bc40664649f6a9c1708de6c690110667e7 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:16:43 2022 -0400 🐛 Bugfix clarification. commit 1ff11450315d8be19bc34f0a6d03405fc6df0726 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:04:12 2022 -0400 🐛 BLE minor bugfix.
Thirsrin
pushed a commit
to Thirsrin/connectedhomeip
that referenced
this pull request
Jul 12, 2023
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 30fd4a1e5232497a98ba2048af53e574f3e20b4c Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jul 6 14:42:12 2022 -0400 🛠 Rebase Fix. commit 83b558f3d8e64817d22feefe0051631f09bb6aaa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jun 2 16:19:34 2022 -0400 ✨ Edit comment format. commit 468db8bc40664649f6a9c1708de6c690110667e7 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:16:43 2022 -0400 🐛 Bugfix clarification. commit 1ff11450315d8be19bc34f0a6d03405fc6df0726 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:04:12 2022 -0400 🐛 BLE minor bugfix.
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Oct 5, 2023
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 30fd4a1e5232497a98ba2048af53e574f3e20b4c Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jul 6 14:42:12 2022 -0400 🛠 Rebase Fix. commit 83b558f3d8e64817d22feefe0051631f09bb6aaa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jun 2 16:19:34 2022 -0400 ✨ Edit comment format. commit 468db8bc40664649f6a9c1708de6c690110667e7 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:16:43 2022 -0400 🐛 Bugfix clarification. commit 1ff11450315d8be19bc34f0a6d03405fc6df0726 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:04:12 2022 -0400 🐛 BLE minor bugfix.
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
…ist". (#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) #4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) #5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) #6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) #7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) #8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) #9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) #10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) #11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) #12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) #13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) #14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) #15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) #16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) #17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) #18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) #19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) #20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) #21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ist". (project-chip#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) project-chip#3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) project-chip#4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) project-chip#5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) project-chip#6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) project-chip#7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) project-chip#8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) project-chip#9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) project-chip#10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) project-chip#11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) project-chip#12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) project-chip#13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) project-chip#14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) project-chip#15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) project-chip#16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) project-chip#17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) project-chip#18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) project-chip#19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) project-chip#20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) project-chip#21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jan 11, 2024
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 30fd4a1e5232497a98ba2048af53e574f3e20b4c Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jul 6 14:42:12 2022 -0400 🛠 Rebase Fix. commit 83b558f3d8e64817d22feefe0051631f09bb6aaa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jun 2 16:19:34 2022 -0400 ✨ Edit comment format. commit 468db8bc40664649f6a9c1708de6c690110667e7 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:16:43 2022 -0400 🐛 Bugfix clarification. commit 1ff11450315d8be19bc34f0a6d03405fc6df0726 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:04:12 2022 -0400 🐛 BLE minor bugfix.
suveshpratapa
pushed a commit
to suveshpratapa/connectedhomeip
that referenced
this pull request
May 22, 2024
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 30fd4a1e5232497a98ba2048af53e574f3e20b4c Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jul 6 14:42:12 2022 -0400 🛠 Rebase Fix. commit 83b558f3d8e64817d22feefe0051631f09bb6aaa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jun 2 16:19:34 2022 -0400 ✨ Edit comment format. commit 468db8bc40664649f6a9c1708de6c690110667e7 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:16:43 2022 -0400 🐛 Bugfix clarification. commit 1ff11450315d8be19bc34f0a6d03405fc6df0726 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:04:12 2022 -0400 🐛 BLE minor bugfix.
mykrupp
pushed a commit
to mykrupp/connectedhomeip
that referenced
this pull request
Jul 18, 2024
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 30fd4a1e5232497a98ba2048af53e574f3e20b4c Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jul 6 14:42:12 2022 -0400 🛠 Rebase Fix. commit 83b558f3d8e64817d22feefe0051631f09bb6aaa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jun 2 16:19:34 2022 -0400 ✨ Edit comment format. commit 468db8bc40664649f6a9c1708de6c690110667e7 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:16:43 2022 -0400 🐛 Bugfix clarification. commit 1ff11450315d8be19bc34f0a6d03405fc6df0726 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon May 30 16:04:12 2022 -0400 🐛 BLE minor bugfix.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @chrisdecenzo!