Update cxx_rules #10

rwalker-apple · 2020-03-04T19:40:38Z

support skipping GCOV, VALGRIND, etc. with make GCOV=, etc.
support seeing commands with make _@=

woody-apple

I imagine we'll iterate on this a lot, but this looks like a great start to me. Approved.

robszewczyk · 2020-03-04T19:58:56Z

@rwalker-apple I have a favor to ask -- we just merged the CODEOWNERS; would you mind if we close this PR and resubmit just to test that the reviewers get tagged?

rwalker-apple · 2020-03-04T20:03:44Z

@rwalker-apple I have a favor to ask -- we just merged the CODEOWNERS; would you mind if we close this PR and resubmit just to test that the reviewers get tagged?

np, rebased

robszewczyk · 2020-03-04T20:04:47Z

@rwalker-apple I have a favor to ask -- we just merged the CODEOWNERS; would you mind if we close this PR and resubmit just to test that the reviewers get tagged?

np, rebased

That worked! Thanks!

robszewczyk

A feature I found helpful and useful in other build systems was to have both the brief and verbose progress in the build. This change moves us in the direction, but not all the way there. I'm happy to approve, but I'd like to understand the end point.

robszewczyk · 2020-03-04T20:09:51Z

.yams/cpp_rules.min

+	$(_@)$(CPPCHECK) $(Module_Test_Includes) $($(*F)_Inc_FLAGS) $<
+endif
+ifdef GCOV
+	$(_@)mv $(*F).gc* $(Test_Dir)


Recommend abstracting all shell commands into the variables (very much along the lines of $(CC), $(CLANG_FORMAT)) Makes for a slightly easier reading experience. I imagine we will be building out the build system into a richer system over time.

I am still unclear what we are building out in terms of the build system. Are we creating a bespoke build system from scratch or iterating on something that starts with a large swath of the features we want?

It'd be good to get some alignment on this before getting too far down a particular path here.

/cc/ @turon

For example, this makes GCOV a first class top-level visible aspect of code coverage. In nlbuild-autotools (a turnkey packaging of GNU autotools), there is support for the 'make coverage' target but the actual platform- and system-specific implementation decides how to carry that out, with slightly differing behavior, for example, on gcc versus clang.

I agree very much that we'll be iterating on (or abandoning) this. We're also evaluating cmake and we can't be sure that we won't need to leverage investments in automake.

This PR is intended to be a small, incremental improvement to aid debugging the current system.

rwalker-apple · 2020-03-04T20:22:47Z

A feature I found helpful and useful in other build systems was to have both the brief and verbose progress in the build. This change moves us in the direction, but not all the way there. I'm happy to approve, but I'd like to understand the end point.

Yep, I agree that'd be nice to have. We don't know the end point for this system, is intended to be a starting point to get us rolling.

woody-apple · 2020-03-04T22:07:57Z

@hawk248 @chrisdecenzo Any thoughts?

woody-apple · 2020-03-06T00:10:35Z

@hawk248 @chrisdecenzo We need an review + approval from one more company. Any chance you folks could help out?

gerickson

Approved on the condition that we identify a line in the sand on when we transition to a "standing on the shoulders of giants" build system that rockets us ahead in terms of solving some basics that are being created whole cloth at the moment.

woody-apple · 2020-03-08T15:18:49Z

@hawk248 Asad, any chance you can take a peek here? Thanks!

hawk248

I am ok with override options for code coverage during lower level build. Ultimately, code coverage can be enforced outside build in a CI pipeline.

woody-apple · 2020-03-08T17:30:26Z

@rwalker-apple Can we fix the merge conflict here? Thanks!

It's not safe to access line editing state from the IO thread while inside readline() on the main thread. Remove the code that attempts to redraw readline after printing logs. This avoids segfaults during logging at the cost of those logs overwriting the prompt (this is not trivial to fix as readline is a blocking API). ================== WARNING: ThreadSanitizer: data race (pid=63005) Write of size 1 at 0x55f81c7745ff by main thread: #0 InteractiveStartCommand::ParseCommand(char*) ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 (chip-tool+0x874911) #1 InteractiveStartCommand::RunCommand() ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:85 (chip-tool+0x874594) #2 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:408 (chip-tool+0x83e478) #3 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #4 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #5 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #6 main <null> (chip-tool+0x569c0a) Previous read of size 1 at 0x55f81c7745ff by thread T5 (mutexes: write M185): #0 LoggingCallback ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:46 (chip-tool+0x874479) #1 chip::Logging::LogV(unsigned char, unsigned char, char const*, __va_list_tag*) ../../src/lib/support/logging/CHIPLogging.cpp:221 (chip-tool+0x8ee4dc) #2 chip::Logging::Log(unsigned char, unsigned char, char const*, ...) ../../src/lib/support/logging/CHIPLogging.cpp:172 (chip-tool+0x8ee30a) #3 chip::app::ReadClient::RefreshLivenessCheckTimer() <null> (chip-tool+0x8b1746) #4 chip::app::ReadClient::ProcessSubscribeResponse(chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:845 (chip-tool+0x8b20ec) #5 chip::app::ReadClient::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:409 (chip-tool+0x8ae2a4) #6 chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) <null> (chip-tool+0xa0517a) #7 operator()<chip::Messaging::ExchangeContext> ../../src/messaging/ExchangeMgr.cpp:219 (chip-tool+0xa08c73) #8 Call ../../src/lib/support/Pool.h:126 (chip-tool+0xa0912d) #9 chip::internal::HeapObjectList::ForEachNode(void*, chip::Loop (*)(void*, void*)) ../../src/lib/support/Pool.cpp:127 (chip-tool+0x8ee05a) #10 ForEachActiveObject<chip::Messaging::ExchangeManager::OnMessageReceived(const chip::PacketHeader&, const chip::PayloadHeader&, const chip::SessionHandle&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&)::<lambda(auto:2*)> > ../../src/lib/support/Pool.h:396 (chip-tool+0xa08d10) #11 chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ../../src/messaging/ExchangeMgr.cpp:212 (chip-tool+0xa07e91) #12 chip::SessionManager::SecureUnicastMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:616 (chip-tool+0xa1548b) #13 chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:443 (chip-tool+0xa14426) #14 chip::TransportMgrBase::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/TransportMgrBase.cpp:76 (chip-tool+0xa17dfa) #15 chip::Transport::Base::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/raw/Base.h:102 (chip-tool+0xb19728) #16 chip::Transport::UDP::OnUdpReceive(chip::Inet::UDPEndPoint*, chip::System::PacketBufferHandle&&, chip::Inet::IPPacketInfo const*) ../../src/transport/raw/UDP.cpp:122 (chip-tool+0xb1a48b) #17 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>) ../../src/inet/UDPEndPointImplSockets.cpp:688 (chip-tool+0xb00aa0) #18 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>, long) ../../src/inet/UDPEndPointImplSockets.cpp:569 (chip-tool+0xafff89) #19 chip::System::LayerImplSelect::HandleEvents() ../../src/system/SystemLayerImplSelect.cpp:406 (chip-tool+0xb07563) #20 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:181 (chip-tool+0x98a227) #21 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #22 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Location is global '(anonymous namespace)::gIsCommandRunning' of size 1 at 0x55f81c7745ff (chip-tool+0x000000c485ff) Mutex M185 (0x55f81c776180) created at: #0 pthread_mutex_lock ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4240 (libtsan.so.0+0x4f30a) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_LockChipStack() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:78 (chip-tool+0x989e90) #2 chip::DeviceLayer::PlatformManager::LockChipStack() ../../src/include/platform/PlatformManager.h:410 (chip-tool+0x988fa5) #3 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:170 (chip-tool+0x98a147) #4 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #5 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Thread T5 (tid=63013, running) created by main thread at: #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x5ad75) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_StartEventLoopTask() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:231 (chip-tool+0x98a40a) #2 chip::DeviceLayer::PlatformManager::StartEventLoopTask() ../../src/include/platform/PlatformManager.h:375 (chip-tool+0xaacca2) #3 chip::Controller::DeviceControllerFactory::ServiceEvents() ../../src/controller/CHIPDeviceControllerFactory.cpp:331 (chip-tool+0xab0417) #4 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:403 (chip-tool+0x83e353) #5 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #6 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #7 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #8 main <null> (chip-tool+0x569c0a) SUMMARY: ThreadSanitizer: data race ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 in InteractiveStartCommand::ParseCommand(char*) ==================

It's not safe to access line editing state from the IO thread while inside readline() on the main thread. Remove the code that attempts to redraw readline after printing logs. This avoids segfaults during logging at the cost of those logs overwriting the prompt (this is not trivial to fix as readline is a blocking API). ================== WARNING: ThreadSanitizer: data race (pid=63005) Write of size 1 at 0x55f81c7745ff by main thread: #0 InteractiveStartCommand::ParseCommand(char*) ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 (chip-tool+0x874911) #1 InteractiveStartCommand::RunCommand() ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:85 (chip-tool+0x874594) #2 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:408 (chip-tool+0x83e478) #3 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #4 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #5 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #6 main <null> (chip-tool+0x569c0a) Previous read of size 1 at 0x55f81c7745ff by thread T5 (mutexes: write M185): #0 LoggingCallback ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:46 (chip-tool+0x874479) #1 chip::Logging::LogV(unsigned char, unsigned char, char const*, __va_list_tag*) ../../src/lib/support/logging/CHIPLogging.cpp:221 (chip-tool+0x8ee4dc) #2 chip::Logging::Log(unsigned char, unsigned char, char const*, ...) ../../src/lib/support/logging/CHIPLogging.cpp:172 (chip-tool+0x8ee30a) #3 chip::app::ReadClient::RefreshLivenessCheckTimer() <null> (chip-tool+0x8b1746) #4 chip::app::ReadClient::ProcessSubscribeResponse(chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:845 (chip-tool+0x8b20ec) #5 chip::app::ReadClient::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:409 (chip-tool+0x8ae2a4) #6 chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) <null> (chip-tool+0xa0517a) #7 operator()<chip::Messaging::ExchangeContext> ../../src/messaging/ExchangeMgr.cpp:219 (chip-tool+0xa08c73) #8 Call ../../src/lib/support/Pool.h:126 (chip-tool+0xa0912d) #9 chip::internal::HeapObjectList::ForEachNode(void*, chip::Loop (*)(void*, void*)) ../../src/lib/support/Pool.cpp:127 (chip-tool+0x8ee05a) #10 ForEachActiveObject<chip::Messaging::ExchangeManager::OnMessageReceived(const chip::PacketHeader&, const chip::PayloadHeader&, const chip::SessionHandle&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&)::<lambda(auto:2*)> > ../../src/lib/support/Pool.h:396 (chip-tool+0xa08d10) #11 chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ../../src/messaging/ExchangeMgr.cpp:212 (chip-tool+0xa07e91) #12 chip::SessionManager::SecureUnicastMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:616 (chip-tool+0xa1548b) #13 chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:443 (chip-tool+0xa14426) #14 chip::TransportMgrBase::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/TransportMgrBase.cpp:76 (chip-tool+0xa17dfa) #15 chip::Transport::Base::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/raw/Base.h:102 (chip-tool+0xb19728) #16 chip::Transport::UDP::OnUdpReceive(chip::Inet::UDPEndPoint*, chip::System::PacketBufferHandle&&, chip::Inet::IPPacketInfo const*) ../../src/transport/raw/UDP.cpp:122 (chip-tool+0xb1a48b) #17 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>) ../../src/inet/UDPEndPointImplSockets.cpp:688 (chip-tool+0xb00aa0) #18 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>, long) ../../src/inet/UDPEndPointImplSockets.cpp:569 (chip-tool+0xafff89) #19 chip::System::LayerImplSelect::HandleEvents() ../../src/system/SystemLayerImplSelect.cpp:406 (chip-tool+0xb07563) #20 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:181 (chip-tool+0x98a227) #21 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #22 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Location is global '(anonymous namespace)::gIsCommandRunning' of size 1 at 0x55f81c7745ff (chip-tool+0x000000c485ff) Mutex M185 (0x55f81c776180) created at: #0 pthread_mutex_lock ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4240 (libtsan.so.0+0x4f30a) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_LockChipStack() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:78 (chip-tool+0x989e90) #2 chip::DeviceLayer::PlatformManager::LockChipStack() ../../src/include/platform/PlatformManager.h:410 (chip-tool+0x988fa5) #3 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:170 (chip-tool+0x98a147) #4 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #5 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Thread T5 (tid=63013, running) created by main thread at: #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x5ad75) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_StartEventLoopTask() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:231 (chip-tool+0x98a40a) #2 chip::DeviceLayer::PlatformManager::StartEventLoopTask() ../../src/include/platform/PlatformManager.h:375 (chip-tool+0xaacca2) #3 chip::Controller::DeviceControllerFactory::ServiceEvents() ../../src/controller/CHIPDeviceControllerFactory.cpp:331 (chip-tool+0xab0417) #4 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:403 (chip-tool+0x83e353) #5 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #6 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #7 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #8 main <null> (chip-tool+0x569c0a) SUMMARY: ThreadSanitizer: data race ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 in InteractiveStartCommand::ParseCommand(char*) ================== Co-authored-by: Michael Spang <spang@google.com>

Merge in WMN_TOOLS/matter from example_newLight to silabs Squashed commit of the following: commit 4bf0c26bd4829ec146574c99a77e4c58d242af21 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Fri Jul 15 16:28:07 2022 -0400 ✨ Code improvements. commit 0cd0466e28a0e712636bce13ade7498a5ef47d3f Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jul 14 19:27:00 2022 -0400 ⌛️ Update the light app to use the new GSDK pwm drivers. commit dd9ecb156626b149cfdce49ec93e776499439594 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jul 11 20:34:22 2022 -0400 🏗 Remove int usage and code clarifications. commit b745a8622636a608aeb869cab0f3106ac44773aa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jul 4 19:08:22 2022 -0400 🛡 Include guards for incompatible boards. commit 2bde7a13337f2658ec7de4d8c37e7b00821722c9 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jun 29 16:48:22 2022 -0400 ✨ Code improvements. commit 9fbb2497e7be70c97a70ad694e757e1009c5f837 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jun 27 22:07:20 2022 -0400 🎨 Add Color Control. commit a3640854c813350323b7be18e8b7040c5c9fdfb8 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jun 20 11:01:09 2022 -0400 →← Fix merge conflict.

…ist". (#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) #4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) #5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) #6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) #7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) #8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) #9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) #10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) #11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) #12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) #13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) #14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) #15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) #16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) #17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) #18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) #19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) #20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) #21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)

…ist". (project-chip#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) project-chip#3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) project-chip#4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) project-chip#5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) project-chip#6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) project-chip#7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) project-chip#8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) project-chip#9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) project-chip#10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) project-chip#11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) project-chip#12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) project-chip#13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) project-chip#14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) project-chip#15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) project-chip#16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) project-chip#17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) project-chip#18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) project-chip#19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) project-chip#20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) project-chip#21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)

Merge in WMN_TOOLS/matter from example_newLight to silabs Squashed commit of the following: commit 4bf0c26bd4829ec146574c99a77e4c58d242af21 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Fri Jul 15 16:28:07 2022 -0400 ✨ Code improvements. commit 0cd0466e28a0e712636bce13ade7498a5ef47d3f Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Thu Jul 14 19:27:00 2022 -0400 ⌛️ Update the light app to use the new GSDK pwm drivers. commit dd9ecb156626b149cfdce49ec93e776499439594 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jul 11 20:34:22 2022 -0400 🏗 Remove int usage and code clarifications. commit b745a8622636a608aeb869cab0f3106ac44773aa Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jul 4 19:08:22 2022 -0400 🛡 Include guards for incompatible boards. commit 2bde7a13337f2658ec7de4d8c37e7b00821722c9 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Wed Jun 29 16:48:22 2022 -0400 ✨ Code improvements. commit 9fbb2497e7be70c97a70ad694e757e1009c5f837 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jun 27 22:07:20 2022 -0400 🎨 Add Color Control. commit a3640854c813350323b7be18e8b7040c5c9fdfb8 Author: Elfelsoufi-SiLabs <moaminee@silabs.com> Date: Mon Jun 20 11:01:09 2022 -0400 →← Fix merge conflict.

woody-apple self-requested a review March 4, 2020 19:53

woody-apple approved these changes Mar 4, 2020

View reviewed changes

rwalker-apple force-pushed the Update-cxx_rules branch from f10024a to 1448a35 Compare March 4, 2020 20:02

rwalker-apple requested review from anush-apple, chrisdecenzo, gerickson, hawk248 and robszewczyk as code owners March 4, 2020 20:02

robszewczyk approved these changes Mar 4, 2020

View reviewed changes

rwalker-apple force-pushed the Update-cxx_rules branch 2 times, most recently from 07b9bd0 to 8a5fdaf Compare March 4, 2020 21:54

pan-apple mentioned this pull request Mar 6, 2020

Fix code coverage reporting during build process #14

Merged

gerickson approved these changes Mar 6, 2020

View reviewed changes

hawk248 approved these changes Mar 8, 2020

View reviewed changes

Update cxx_rules

20abdf7

rwalker-apple force-pushed the Update-cxx_rules branch from 8a5fdaf to 20abdf7 Compare March 9, 2020 18:55

woody-apple merged commit 5346ce0 into project-chip:master Mar 9, 2020

rwalker-apple deleted the Update-cxx_rules branch March 9, 2020 20:33

vivien-apple mentioned this pull request Jun 3, 2020

[Spec-SetupPayload] TLV examples in the specification are wrong #938

Closed

cjandhyala mentioned this pull request Oct 30, 2020

Chip tool server crash on raspi4 when doing connect using python chip-device-ctrl #3548

Closed

mspang mentioned this pull request Feb 22, 2021

crash in GetBluezConnectionViaDevice #4962

Closed

yufengwangca mentioned this pull request Mar 14, 2021

Fix random Segmentation fault issue in CRMP testing. #5361

Merged

turon mentioned this pull request Sep 24, 2022

[BUG] [crash] [mrp] Receiving a mid-exchange message without ACK bit set will crash #22854

Closed

jagadeesh-ayla mentioned this pull request Feb 14, 2023

[BUG] JNI crash when we have active event/path subscriptions #25044

Closed

yzm157 mentioned this pull request Mar 22, 2023

[Linux] Run only one GLib main event loop #23320

Merged

mukulag8293 mentioned this pull request Apr 13, 2023

[BUG] Crash(SIGSEGV) seen in minimal mdns code during repeated commissioning and unpair attempts #26091

Open

yunhanw-google mentioned this pull request Jul 28, 2023

[BUG] thread network provisioning crash in cirque test #28352

Open

This was referenced Aug 1, 2023

[Android][CHIPTool][Crash] libCHIPController.so crash when invoke readOnOffAttribute method of OnOffCluster class #28429

Closed

[Android][CHIPTool][Crash] crash occured when connect matter device using getConnectedDevicePointer #28430

Closed

netscell mentioned this pull request Sep 5, 2023

[BUG] crash in libCHipcontroller.so #29061

Closed

M201370367 mentioned this pull request Oct 25, 2023

[BUG] crash: JNI NewByteArray called with pending exception java.lang.AbstractMethodError #29997

Open

yunhanw-google mentioned this pull request Dec 12, 2023

[1.3] Persistent Subscription crash in LIT example app #30944

Open

joonhaengHeo mentioned this pull request Dec 20, 2023

[BUG][Android] Crash Android chip-tool when reading event #31127

Closed

pgatti86 mentioned this pull request Dec 22, 2023

[BUG] [Android] crash happens when device reboot #30624

Closed

yunhanw-google mentioned this pull request Feb 1, 2024

Remove dependency of InteractionModelEngine in CommandHandler #31830

Merged

salvio96 mentioned this pull request Feb 21, 2024

[1.2] All-cluster-app pairing with chip tool #32037

Closed

JasonClark2 mentioned this pull request Apr 3, 2024

[Test Failed] [BUG] When I pair with a matter device, it sometimes crashes. I'm sure I'm using the same method, but it crashes every now and then. The second time the pairing succeeds, #32826

Open

mhwang408 mentioned this pull request Jun 27, 2024

[BUG] uninitialized PairingCommand::mDiscriminator leads "chip-tool pairing onnetwork" to die #34096

Closed

Alami-Amine mentioned this pull request Sep 3, 2024

[pw_fuzzer] Blocker in integration of Test Fixtures #35369

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update cxx_rules #10

Update cxx_rules #10

rwalker-apple commented Mar 4, 2020

woody-apple left a comment

robszewczyk commented Mar 4, 2020

rwalker-apple commented Mar 4, 2020

robszewczyk commented Mar 4, 2020

robszewczyk left a comment

robszewczyk Mar 4, 2020

gerickson Mar 4, 2020

gerickson Mar 4, 2020

rwalker-apple Mar 4, 2020 •

edited

Loading

rwalker-apple commented Mar 4, 2020

woody-apple commented Mar 4, 2020

woody-apple commented Mar 6, 2020

gerickson left a comment

woody-apple commented Mar 8, 2020

hawk248 left a comment

woody-apple commented Mar 8, 2020

Update cxx_rules #10

Update cxx_rules #10

Conversation

rwalker-apple commented Mar 4, 2020

woody-apple left a comment

Choose a reason for hiding this comment

robszewczyk commented Mar 4, 2020

rwalker-apple commented Mar 4, 2020

robszewczyk commented Mar 4, 2020

robszewczyk left a comment

Choose a reason for hiding this comment

robszewczyk Mar 4, 2020

Choose a reason for hiding this comment

gerickson Mar 4, 2020

Choose a reason for hiding this comment

gerickson Mar 4, 2020

Choose a reason for hiding this comment

rwalker-apple Mar 4, 2020 • edited Loading

Choose a reason for hiding this comment

rwalker-apple commented Mar 4, 2020

woody-apple commented Mar 4, 2020

woody-apple commented Mar 6, 2020

gerickson left a comment

Choose a reason for hiding this comment

woody-apple commented Mar 8, 2020

hawk248 left a comment

Choose a reason for hiding this comment

woody-apple commented Mar 8, 2020

rwalker-apple Mar 4, 2020 •

edited

Loading