-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Re-enable TAPI and change symbol visibility management #31166
Darwin: Re-enable TAPI and change symbol visibility management #31166
Conversation
PR #31166: Size comparison from ab58186 to 8c1e2f6 Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
2017f3e
to
d1f275f
Compare
PR #31166: Size comparison from ab58186 to d1f275f Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to see the missing availability annotations finally added!
Hm the summary page claims the build succeeds but there is some test problem, but when I download the log archive I actually see these build errors:
|
Symbols are now hidden by default, but anything annotated with API availability (or deprecation, since that implies previous availability) is exported. Also add missing API availability to a number of classes that were introduced in the initial release.
d1f275f
to
82943d1
Compare
PR #31166: Size comparison from db7d887 to 82943d1 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31166: Size comparison from db7d887 to 2e4c97d Increases (5 builds for nrfconnect, qpg)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #31166: Size comparison from db7d887 to fd39642 Increases above 0.2%:
Increases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for esp32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31166: Size comparison from db7d887 to 53eab75 Increases above 0.2%:
Increases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for esp32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31166: Size comparison from db7d887 to 5f66255 Full report (4 builds for cc32xx, mbed, stm32)
|
PR #31166: Size comparison from db7d887 to b34a693 Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Seems like TAPI is happy now, but now I'm seeing this error in the Darwin build that I don't get locally:
Any ideas @bzbarsky-apple ? |
PR #31166: Size comparison from db7d887 to 8dd1c0e Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Symbols are now hidden by default, but anything annotated with API availability (or deprecation, since that implies previous availability) is exported. Also add missing API availability to a number of classes that were introduced in the initial release.