-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Add ruff as Python linter #32384
[Python] Add ruff as Python linter #32384
Conversation
NOTE: This requires a new chip-build release first. I am not sure what the process is to update the container. Should I create a separate PR to add |
PR #32384: Size comparison from 0af9905 to bc62fcc Decreases (3 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32384: Size comparison from 0af9905 to a099cb2 Full report (16 builds for cc13x4_26x4, cc32xx, k32w, mbed, qpg, stm32)
|
PR #32384: Size comparison from 0af9905 to 5b2aff4 Decreases (3 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32384: Size comparison from 0af9905 to d77033d Increases above 0.2%:
Increases (5 builds for linux)
Decreases (52 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, linux, nrfconnect, qpg, stm32, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
82277be
to
2035866
Compare
PR #32384: Size comparison from 9e8a77f to 2035866 Decreases (3 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
2035866
to
0c1c308
Compare
PR #32384: Size comparison from 9e8a77f to 0c1c308 Decreases (3 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a proper PR description why the change is being made etc.?
Good point, I've added a description to the PR. Note that I am not sure yet if it (is/will be) a good idea to use its formatting capabilities. The repo is currently using restyled, for formatting, and Ruff is (not yet) supported. |
6ed674f
to
25c4546
Compare
PR #32384: Size comparison from aae22c1 to 25c4546 Decreases (1 build for efr32)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
25c4546
to
eac0fbe
Compare
PR #32384: Size comparison from f834092 to eac0fbe Decreases (1 build for efr32)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
eac0fbe
to
ad500dd
Compare
PR #32384: Size comparison from c554f44 to ad500dd Decreases (2 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
* Add ruff as Python linter * Add ruff to linter workflow * Remove flake8 * Set default line-length and explicitly select rules * Address REPL Test issue * Explicitly set line lenght for autopep8 * Fix restyled config
This adds Ruff as Python linter. Ruff is an extremely fast Python linter and code formatter, written in Rust. Currently only it's linter capabilities are used. It replace flake8 currently in that capacity. Compared to flake8 it is much faster, and in the future additional checks can be enabled.