VS Code Python Formatting #34475
Merged
VS Code Python Formatting #34475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34475: Size comparison from 8306353 to 5bd315f Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, qpg, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/vscodePythonAutopep8
branch
from
5bd315f to
8424879
Compare
|
PR #34475: Size comparison from 8306353 to 8424879 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 24, 2024
|
Why not go straight for ruff and skip autopep8 and isort ? Also 132 characters for Python code is not very common. Most projects choose 100 or even 88 characters... Just my 2 cents as I have always wondered a bit why the python code in the sdk is not exactly pep formatted. We can do a PR to adjust it but it will also mean a very large diff as all code will be re-formatted. |
tehampson
approved these changes
Jul 24, 2024
bzbarsky-apple
approved these changes
Jul 26, 2024
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* add python formatter arguments to vscode .settings * add python formatters to recommended Extensions
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* add python formatter arguments to vscode .settings * add python formatters to recommended Extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autopep8andisortas recommended extensions when installing a new VSCode workspace (sinceisortis also part of restyled settings Add isort formatter to restyled configuration #24148)