[Silabs] Fix silabs energy mangement app #35658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… README. Added test event triggers.
|
Review changes with SemanticDiff. |
mkardous-silabs
changed the title
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
lpbeliveau-silabs
approved these changes
Sep 18, 2024
|
PR #35658: Size comparison from 2396bb4 to 1f3b31e Full report (78 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35658: Size comparison from 2396bb4 to 2f17224 Increases above 0.2%:
Full report (78 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
added
the
changing-submodules-on-purpose
|
PR #35658: Size comparison from 2396bb4 to 05be810 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 20, 2024
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
* Fix BUILD.gn which was broken in moving files around in energy management app. * Added BUILD.gn arguments to enable different feature support. Updated README. Added test event triggers. * Removed blank lines * Added test event triggers * [Silabs] Fix silabs energy mangement app * Fix gn conditional inclusions * Fix GN conflict --------- Co-authored-by: James Harrow <james.harrow@gmail.com> Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com> Co-authored-by: Faisal Bhaiyat <faisal.bhaiyat@silabs.com>
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
* Fix BUILD.gn which was broken in moving files around in energy management app. * Added BUILD.gn arguments to enable different feature support. Updated README. Added test event triggers. * Removed blank lines * Added test event triggers * [Silabs] Fix silabs energy mangement app * Fix gn conditional inclusions * Fix GN conflict --------- Co-authored-by: James Harrow <james.harrow@gmail.com> Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com> Co-authored-by: Faisal Bhaiyat <faisal.bhaiyat@silabs.com>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Fix BUILD.gn which was broken in moving files around in energy management app. * Added BUILD.gn arguments to enable different feature support. Updated README. Added test event triggers. * Removed blank lines * Added test event triggers * [Silabs] Fix silabs energy mangement app * Fix gn conditional inclusions * Fix GN conflict --------- Co-authored-by: James Harrow <james.harrow@gmail.com> Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com> Co-authored-by: Faisal Bhaiyat <faisal.bhaiyat@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the silabs energy management app.
Tests
Manual tests to validate the app can be build and successfully process test event trigger commands