Fix null pointer issue in CHIPMemString #35840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
|
Good Catch! can you please sign the CLA though. |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
@Alami-Amine Thank you for the guidance! I've rechecked the CLA, and it should be signed correctly. |
|
PR #35840: Size comparison from 6bbe1d6 to c32fc4d Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
approved these changes
Sep 30, 2024
andy31415
approved these changes
Sep 30, 2024
bzbarsky-apple
approved these changes
Sep 30, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CHIPMemString.h:127:22: runtime error: null pointer passed as argument 2, which is declared to never be nullChanges
CHIPMemString.Reproducing
./out/linux-x64-all-clusters-ubsan-clang/chip-all-clusters-app ... [1727661001.811740][5218:5218] CHIP:EM: Flushed pending ack for MessageCounter:263064390 on exchange 45711r [1727661001.812225][5218:5218] CHIP:FP: Validating NOC chain [1727661001.813018][5218:5218] CHIP:FP: NOC chain validation successful ../../examples/all-clusters-app/linux/third_party/connectedhomeip/src/lib/support/CHIPMemString.h:127:22: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:44:28: note: nonnull attribute specified here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../examples/all-clusters-app/linux/third_party/connectedhomeip/src/lib/support/CHIPMemString.h:127:22 [1727661001.813423][5218:5218] CHIP:FP: Added new fabric at index: 0x1 [1727661001.813438][5218:5218] CHIP:FP: Assigned compressed fabric ID: 0x653BF2694F51D787, node ID: 0x0000000000000001 [1727661001.813445][5218:5218] CHIP:TS: Last Known Good Time: 2023-10-14T01:16:48