Move the --dac_provider option from all clusters apps to common place. #36886
+29
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36886: Size comparison from b0d0614 to ee77a3a Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
all-clusters-app and all-clusters-minimal-app has the --dac_provider option which lets us inject the custom dacs in the applications. moved this option from these apps to examples/platform/linux so that wide range of applications can levarage this. This would be useful in testing device attestation revocation cases.
shubhamdp
force-pushed
the
dac-provider-option
branch
from
ee77a3a to
852ca31
Compare
|
PR #36886: Size comparison from 238e801 to 852ca31 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36886: Size comparison from 238e801 to 1e42cc0 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Dec 20, 2024
tcarmelveilleux
approved these changes
Dec 20, 2024
dhrishi
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all-clusters-app and all-clusters-minimal-app has the
--dac_provideroption which lets us inject the custom dacs in the applications.moved this option from these apps to examples/platform/linux so that wide range of applications can levarage this.
This would be useful in testing device attestation revocation cases.
Fixes #26434
This is a building block towards creating the integration tests for dac revocation
Testing
Tested manually with all-clusters-app, all-clusters-minimal-app, and lighting-app that the
--dac_provideroption works, and the DACs provided in the json file does reflect.This option is used in the
src/app/tests/suites/certification/Test_TC_DA_1_8.yamlandsrc/app/tests/suites/certification/Test_TC_DA_1_4.yamltests, and few TC_DA python tests as well. So, this will be tested in the CI.Also generated the revocation set from the injected DAC and verified that the attestation revocation error shows up.