-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch ble adapter listing to use the native bluez interface. #4839
Merged
mspang
merged 16 commits into
project-chip:master
from
andy31415:02_native_list_adapters
Feb 16, 2021
Merged
Switch ble adapter listing to use the native bluez interface. #4839
mspang
merged 16 commits into
project-chip:master
from
andy31415:02_native_list_adapters
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
force-pushed
the
02_native_list_adapters
branch
from
February 12, 2021 17:37
1ad8af0
to
3f2d3f0
Compare
andy31415
force-pushed
the
02_native_list_adapters
branch
from
February 12, 2021 17:46
b9b42c7
to
b2ddee7
Compare
andy31415
force-pushed
the
02_native_list_adapters
branch
from
February 12, 2021 21:05
fe81960
to
029f21f
Compare
andy31415
force-pushed
the
02_native_list_adapters
branch
from
February 12, 2021 21:13
029f21f
to
7279672
Compare
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
hawk248 and
jelderton
February 12, 2021 21:14
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst and
woody-apple
February 12, 2021 21:14
msandstedt
approved these changes
Feb 12, 2021
bzbarsky-apple
approved these changes
Feb 12, 2021
mspang
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #4838
Problem
Python implementation uses a native bluez for BLE operations.
CHIP BLE pairing requires native connection objects, so interfacing with native code is easier if native
code is used throughout for now. Implemeting a pure python chip would be very useful but is not attainable at the moment.
Summary of Changes
Defines a chip.native module to handle loading of the chip native library and switches chip.ble adapter listing to use the native interface.
Example output of
chip-repl
: