Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate dedicated bluez directory for linux BLE interfacing #4846

Merged
merged 23 commits into from
Feb 19, 2021

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Feb 12, 2021

Problem

CHIPBluezHelpers.cpp is growing too large (>2000 lines right now) to easily maintain.

Summary of Changes

Place bluez code into a dedicated folder and split out the first stand-alone item: AdapterIterator.

This is a followup of #4839 and prepares for some additional changes to support BLE scanning:

  • main loop will need to be split to support actions for both 'scan and connect' and 'scan and report'
  • will later implement a 'scan for CHIP BLE device'

@andy31415
Copy link
Contributor Author

Converted to draft until patch that preceeds it lands, to avoid having large code deltas.

Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andy31415 andy31415 merged commit 6d06bee into project-chip:master Feb 19, 2021
@andy31415 andy31415 deleted the 03_move_bluez_helpers branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants