-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate dedicated bluez directory for linux BLE interfacing #4846
Merged
andy31415
merged 23 commits into
project-chip:master
from
andy31415:03_move_bluez_helpers
Feb 19, 2021
Merged
Separate dedicated bluez directory for linux BLE interfacing #4846
andy31415
merged 23 commits into
project-chip:master
from
andy31415:03_move_bluez_helpers
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to draft until patch that preceeds it lands, to avoid having large code deltas. |
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst and
woody-apple
February 16, 2021 21:29
yunhanw-google
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
jelderton
approved these changes
Feb 17, 2021
msandstedt
approved these changes
Feb 17, 2021
mspang
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIPBluezHelpers.cpp
is growing too large (>2000 lines right now) to easily maintain.Summary of Changes
Place bluez code into a dedicated folder and split out the first stand-alone item: AdapterIterator.
This is a followup of #4839 and prepares for some additional changes to support BLE scanning: