-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Tests workflow, will house certification tests #7381
Conversation
Note: Linux crashes now in Exchange, not sure why. Would love eyes on it. Need to also have this auto gen tests. |
Size increase report for "esp32-example-build" from bfe602b
Full report output
|
Size increase report for "gn_qpg6100-example-build" from bfe602b
Full report output
|
OK, this is ready for integration now. Thanks @pan-apple! This covers testing of: Note: there are races in our stack that this has already found, and will continue to do so. A couple major ones are fixed/worked around in here Next steps post this PR are: @Damian-Nordic @andy31415 @jepenven-silabs @hawk248 @jelderton @bzbarsky-apple ? |
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Remove this work around due to crashes when storage is accessed from multiple threads and passed aroundconnectedhomeip/examples/chip-tool/commands/common/Commands.cpp Lines 41 to 48 in 7020bbc
This comment was generated by todo based on a
|
Remove this workaround once we understand the message queue and shutdown raceconnectedhomeip/examples/chip-tool/commands/tests/TestCommand.cpp Lines 58 to 62 in 7020bbc
This comment was generated by todo based on a
|
echo " ===== Running test: $i" | ||
echo " * Starting cluster server" | ||
rm -rf /tmp/chip_tool_config.ini | ||
sleep 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should avoid having "sleep" calls anywhere in the code. This seems to indicate we have some racing issues here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. We do; see all the TODO comments. I have PRs up to fix the races (#7428 and #7430) and a PR up at #7433 that removes the sleeps and another at #7434 to remove the TODO workarounds. Reviews on those would be much appreciated, @andy31415 !
) * Initial stab * Adding test runs * Removing this * Making this +x * Oops * Running all tests * Delete storage just inc ase * Trying to run this in darwin too * Moving darwin into tests * Testing out mbedtls * Fixing gStorage * Fixing quoting * Wait for pairing * next * Trying 0.0.0.0 * ::1 * Testing cache * Removing cache * IPv6 localhost for today * IPv6 localhost * Moving to this pin code * check validity of mTransportMgr * collect core dump * remove controller shutdown * delay controller shutdown in the test * restyled * Removing this, not needed anymore * Empty defines * Update scripts/tests/test_suites.sh Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Adding todos Co-authored-by: Pankaj Garg <pgarg2@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Problem
Now that we have a simple description language for tests, certification will use it to run all tests in CI for the SDK
Change overview
Testing
How was this tested? (at least one bullet point required)