Remove workarounds for threading problems from chip-tool commands. #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
approved these changes
Jun 7, 2021
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
msandstedt
approved these changes
Jun 7, 2021
yunhanw-google
approved these changes
Jun 8, 2021
This change depends on project-chip#7428 and project-chip#7430 which fix the problems properly. Fixes project-chip#7408 Fixes project-chip#7409 Fixes project-chip#7410
bzbarsky-apple
force-pushed
the
remove-workarounds
branch
from
2a385a6 to
7b039d7
Compare
|
@andy31415 @Damian-Nordic please take a look? |
Damian-Nordic
approved these changes
Jun 9, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…roject-chip#7434) This change depends on project-chip#7428 and project-chip#7430 which fix the problems properly. Fixes project-chip#7408 Fixes project-chip#7409 Fixes project-chip#7410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on
#7428 and
#7430 which fix
the problems properly.
Fixes #7408
Fixes #7409
Fixes #7410
Problem
We have some workarounds added in #7381 that we don't really need once we do #7428 and #7430
Change overview
Remove the workarounds.
Testing
Ran the tests that #7381 added by hand many hundreds of times, without any problems.