-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Window app commissioning flow #7526
Conversation
Investigating this ZAP failure in the CI. The CI does a regen and removes commands that should not be removed. It happends locally also, but once committed the regen does the opposite, re-adds the commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, though maybe removing instead of disabling the endpoint-0 bits from the other endpoint would have made more sense...
I wonder whether the zap failure is similar to the one that keeps biting tv-app. @vivien-apple |
@bzbarsky-apple I agree, Not sure how to effectively delete them in zap. In endpoint 1, I changed all of them from"Server" to not a value. Created endpoint 0 and set them to server. I thought the regen would delete them from endpoint 1 but it just disabled them. Is there another way to go? |
I don't know. I have yet to use the ZAP UI; I've just ended up hand-editing .zap files as needed... |
@bzbarsky-apple I just validated with the zap team. Also the generation issue adding/removing the commands are due to a helper issue with incomming commands. and that helper should be replace by a new one for command parsing |
f3f0d99
to
2ea151e
Compare
@jmartinez-silabs - merge conflicts |
455c6a5
to
2bac1b1
Compare
/rebase |
@jmartinez-silabs these look like real errors. |
@woody-apple Right those are real errors that I fixed with #7619 . I will rebase this PR, should fix it. |
… (window cover) in ep 1
regen after rebase Rebase and regen for updates
…_CLUSTER in the modified window-app.zap file Regen files
Rebase and Regen2
2bac1b1
to
2378930
Compare
This reverts commit 844c65b.
@jmartinez-silabs This was reverted because of a merge issue that caused it to break the build... Needs to be rebased on ToT, codegen rerun, and the build issue addressed. |
@bzbarsky-apple ok thank you Boris. Will address this. |
…ct-chip#7698) This reverts commit 844c65b.
* move operational clusters to endpoint 0, keep the application cluster (window cover) in ep 1 * regenerate files with zap regen after rebase Rebase and regen for updates * Rebase and regen * Fix missed issue when rebabse didn't remove TRUSTED_ROOT_CERTIFICATES_CLUSTER in the modified window-app.zap file Regen files * Rebase and Regen Rebase and Regen2 * rebase®en
…ct-chip#7698) This reverts commit 844c65b.
Problem
Commissioning flow is broken on window-app as the operational clusters have not been moved to endpoint 0 for this example common generated code.
Change overview
Modify window-app.zap to move all operational clusters (NetworkCommissioning, Basic, Diagnostics) to endpoint 0, Keep application cluster (WindowCovering) on endpoint 1
First commit is the changes to the .zap file.
2nd is the regeneration of the files
Testing
Manual testing, validated commissioning flow on python controller with NetworkCommissioning on endpoint 0 and validated WindowCovering cluster commmands are received on the EFR device using endpoint 1