-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Werror=format build error on EFR32, K32W, QPG6100 #7619
Merged
andy31415
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix_print_format
Jun 14, 2021
Merged
Fix Werror=format build error on EFR32, K32W, QPG6100 #7619
andy31415
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix_print_format
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
changed the title
Fix print format
Fix Werror=format build error on EFR32, K32W, QPG6100
Jun 14, 2021
saurabhst
approved these changes
Jun 14, 2021
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jepenven-silabs,
LuDuda,
mspang,
selissia and
woody-apple
June 14, 2021 19:12
mspang
approved these changes
Jun 14, 2021
andy31415
approved these changes
Jun 14, 2021
bzbarsky-apple
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OK to unbreak the tree, but those enums should not be 32-bit to start with, so this is going to break again when they stop doing that.... :(
Admin-merged to bypass CI due to unbounded queue increase and hotfix label. |
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 14, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building EFR32, K32W and QPG6100 fails with -Werror=format= error on master
Not sure how the change that caused those error passed the CI the first time but it now catches them.
Here is the errors on EFR32
Change overview
Replace the print format %d to % PRIu32 and %x to PRIx32 in the errors caught as it is portable to all platforms.
Testing
Running ./gn_build.sh currently fails for me on MAC with some errors in tv-app.
So I did manual builds for
EFR32
./scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/lighting_app BRD4164A
and ran on EFR32MG12 device the newly build firmwareBuild K32W with
./scripts/examples/k32w_example.sh
Build QPG6100
scripts/examples/gn_build_example.sh examples/lock-app/qpg6100 out/qpg6100_lock_app