Re-enable MRP for reads and writes #7991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
wehale and
woody-apple
|
Could you also enable MRP for writes? |
yunhanw-google
approved these changes
Jun 29, 2021
Ugh. I did not realize that got disabled. :( Yes, I can. |
bzbarsky-apple
force-pushed
the
re-enable-read-crmp
branch
from
bb6b434 to
7381841
Compare
With project-chip#7958 merged, this should not be a problem. Prospectively re-enabling for WriteClient too, though that code is not used yet.
bzbarsky-apple
force-pushed
the
re-enable-read-crmp
branch
from
7381841 to
9841b6c
Compare
erjiaqing
approved these changes
Jun 29, 2021
woody-apple
approved these changes
Jun 29, 2021
saurabhst
approved these changes
Jun 29, 2021
Damian-Nordic
approved these changes
Jun 29, 2021
yunhanw-google
changed the title
24 tasks
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
With project-chip#7958 merged, this should not be a problem. Prospectively re-enabling for WriteClient too, though that code is not used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #7958 merged,
this should not be a problem.
Problem
MRP is disabled for reads and writes
Change overview
Re-enable it.
Testing
Ran CI locally and it passes.
We really need to stand up some CI that checks that IM is using MRP across the board, but I haven't quite figured out a good way to do it yet.