Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add e2e tests #47

Merged
merged 28 commits into from
Aug 6, 2024
Merged

ci: add e2e tests #47

merged 28 commits into from
Aug 6, 2024

Conversation

jgrer
Copy link
Collaborator

@jgrer jgrer commented Aug 5, 2024 •
edited
Loading

  • Added new workflow e2e.yaml, which runs on new PR's and pushes to the main branch
  • Designed workflow to install required node packages and docker desktop, then run jest tests
  • Added new folder e2e, which contains the yarn packages needed to run the tests and setup for typescript
  • Created test file "test-copa-extension.test.ts"
  • Added test which inputs "nginx:1.21.6", runs a scan, and confirms that the patched image was created

Closes: #6

jgrer added 21 commits August 2, 2024 16:25
@jgrer
ci: added e2e folder with test file and other config files
f466955 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: remove extra packages and add e2e.yaml file
fc80ccd 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
fix: change to trigger on push to e2e-tests branch
d51a30c 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: change build extension action to use docker build command directl…
d378a6f 
…y to not use multi-platform

Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: input image name and do initial scan
0ace623 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: type instead of fill
73fffc4 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: null check
b5d05b1 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: wait for vuln display after patching
f756613 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: test patched image text display
ae48f87 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: change null evaluations
bfb3101 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: added console logging
db7d99a 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: confirm loading started
a10cf89 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: null check for loading text
ac5cd19 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: await more operations
bc88030 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: add debug text to print patched image name
77566d3 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: swap out if statements for optional chaining
51bc300 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: check for undefined and null
cf6a332 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: run docker images command and check for output
e30493d 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: log output.stdout instead of output object
a324343 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
change tests to run on pushs to main branch
d8048ab 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
style: spelling error
2b1cf51 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
sozercan
sozercan reviewed Aug 6, 2024
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
sozercan
sozercan reviewed Aug 6, 2024
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
sozercan
sozercan reviewed Aug 6, 2024
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
sozercan
sozercan reviewed Aug 6, 2024
View reviewed changes
e2e/e2e.yaml Outdated Show resolved Hide resolved
@ashnamehrotra
Copy link
Contributor

could we try downgrading the dependency review due to actions/dependency-review-action#786?

@jgrer
ci: remove copyright and license text
84a3c70 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: removed duplicate file
0bd2a93 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: remove copyright and license text from other files
13b44d4 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: update all tags to pin to digest + tag & added spaces between steps
acac413 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: downgrade dependency review action to v4.3.2
184af67 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
Copy link
Collaborator Author

jgrer commented Aug 6, 2024

could we try downgrading the dependency review due to actions/dependency-review-action#786?

doesn't seem to work, will wait for update to the action

ashnamehrotra
ashnamehrotra reviewed Aug 6, 2024
View reviewed changes
e2e/.eslintrc Outdated Show resolved Hide resolved
e2e/.gitignore Outdated Show resolved Hide resolved
.github/workflows/dependency-review.yml Outdated Show resolved Hide resolved
@jgrer
style: added new line to two files
2d113a6 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
@jgrer
ci: revert action back to latest version
718a820 
Signed-off-by: Jackson Greer <t-jgreer@microsoft.com>
ashnamehrotra
ashnamehrotra approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnamehrotra ashnamehrotra merged commit cb05c3d into project-copacetic:main Aug 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan left review comments

@ashnamehrotra ashnamehrotra ashnamehrotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgrer @ashnamehrotra @sozercan