Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GETMATIDXVAR macro hides function names #208

Open
no-lex opened this issue Apr 18, 2021 · 0 comments
Open

GETMATIDXVAR macro hides function names #208

no-lex opened this issue Apr 18, 2021 · 0 comments
Labels
misimplementation Circumlocutious or redundant implementation

Comments

@no-lex
Copy link
Member

no-lex commented Apr 18, 2021

It sounds hard to believe, but using macros to construct function names makes them hard to find. Indeed, since GETMATIDXVAR creates a function name by concatenating arguments, it is impossible to Ctrl-F for a function and find where it is defined. To resolve this, GETMATIDXVAR should be hurled directly into the sun, and replaced with literally anything else.

@no-lex no-lex added the misimplementation Circumlocutious or redundant implementation label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misimplementation Circumlocutious or redundant implementation
Projects
None yet
Development

No branches or pull requests

1 participant