Make vacollect a full class #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerspyro
reviewed
Sep 15, 2023
src/engine/render/vacollect.cpp
Outdated
| } | ||
| if(x.tex == y.tex) | ||
| { | ||
| if(x.orient < y.orient) |
There was a problem hiding this comment.
Can't we return false if they're both equal, then simply go:
return x.orient < y.orient;or even:
return x.orient != y.orient && x.orient < y.orient;This is also applicable elsewhere in this file. It's pretty clear in my opinion, I don't think it obscures the code, yet reduces line count.
There was a problem hiding this comment.
As discussed, these two options are a good way to inform the reader that the blocks are part of the same logic, by getting rid of the code blocks.
This will not only shorten the file a bit, but will make the code more legible.
src/engine/render/vacollect.cpp
Outdated
| { | ||
| return true; | ||
| } | ||
| else |
|
|
||
| VARFN(vbosize, maxvbosize, 0, 1<<14, 1<<16, rootworld.allchanged()); | ||
|
|
||
| //vbo (vertex buffer object) enum is local to this file |
There was a problem hiding this comment.
why? is it literally used nowhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges VA collection functions with the object containing its relevant data, allowing the
vacollectobject to have full encapsulation of its fields. Moves thevacollectobject into its own file, separating it from other behavior inoctarender.cpp.No change in the outward behavior of the vertex array collection part of the code is changed; this is a pure refactor besides the changes to the class interface.