Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove codecov and update README #4299

Merged
merged 6 commits into from
Apr 13, 2023
Merged

Remove codecov and update README #4299

merged 6 commits into from
Apr 13, 2023

Conversation

djnakabaale
Copy link
Contributor

Description

@djnakabaale djnakabaale added the smoke-tests pr_check will build the image and run minimal required smokes label Apr 12, 2023
@djnakabaale djnakabaale self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Merging #4299 (9f022da) into main (c988bb7) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4299   +/-   ##
=====================================
  Coverage   94.3%   94.3%           
=====================================
  Files        384     384           
  Lines      32306   32306           
  Branches    3446    3446           
=====================================
+ Hits       30470   30473    +3     
+ Misses      1188    1185    -3     
  Partials     648     648

adberglund
adberglund previously approved these changes Apr 12, 2023
View reviewed changes
@djnakabaale djnakabaale marked this pull request as ready for review April 12, 2023 17:56
@djnakabaale djnakabaale requested review from a team as code owners April 12, 2023 17:56
@maskarb
Copy link
Member

maskarb commented Apr 12, 2023

Does tox run ok locally with these changes?

@djnakabaale
Copy link
Contributor Author

Does tox run ok locally with these changes?

Yes

  py39: commands succeeded
  congratulations :)

@maskarb
Copy link
Member

maskarb commented Apr 12, 2023

Does tox run ok locally with these changes?

Yes

  py39: commands succeeded
  congratulations :)

What happens when you recreate the tox env:

tox -r

maskarb
maskarb approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@maskarb maskarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@djnakabaale djnakabaale merged commit 88bc46c into main Apr 13, 2023
@djnakabaale djnakabaale deleted the update-pipfile branch April 13, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maskarb maskarb maskarb approved these changes

@adberglund adberglund adberglund left review comments

Assignees

@djnakabaale djnakabaale

Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djnakabaale @maskarb @adberglund