This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Remove builder #223
Merged
Remove builder #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
approved these changes
Apr 19, 2023
mariaschett
approved these changes
Apr 19, 2023
README.md
Outdated
| binary is SHA256. For details about the format of the provenance statement please refer to | ||
| [the SLSA provenance documentation](https://slsa.dev/provenance/v0.2). | ||
| [the container-based SLSA3 builder workflow](https://github.com/slsa-framework/slsa-github-generator/blob/f14d71f7a0f58a45b6105c0b6d97c414328ceda0/internal/builders/docker/README.md), | ||
| from the SLSA Framework, builds a binary and a corresponding SLSA v1.0 provenance statement. The |
There was a problem hiding this comment.
nit: builds a binary and "generates"
|
|
||
| The [`verifier`](/internal/verifier/) package provides functionality for verifying an input | ||
| provenance file. The provenance file should follow the | ||
| [Amber provenance](./../pkg/amber/schema/v1/provenance.json) format and provide a list of materials |
There was a problem hiding this comment.
How about Amber? Maybe add a reference to #224?
tiziano88
approved these changes
Apr 19, 2023
cmd/verifier/README.md
Outdated
|
|
||
| To verify a SLSA provenance of the Amber build type run: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
The snippet below is not valid bash, because of the $. Either remove the $, or change the type to console (in which case you can also interleave $-prefixed commands with the corresponding output, if you like).
There was a problem hiding this comment.
Nice. I did not know about the console style.
rbehjati
commented
Apr 19, 2023
README.md
Outdated
| binary is SHA256. For details about the format of the provenance statement please refer to | ||
| [the SLSA provenance documentation](https://slsa.dev/provenance/v0.2). | ||
| [the container-based SLSA3 builder workflow](https://github.com/slsa-framework/slsa-github-generator/blob/f14d71f7a0f58a45b6105c0b6d97c414328ceda0/internal/builders/docker/README.md), | ||
| from the SLSA Framework, builds a binary and a corresponding SLSA v1.0 provenance statement. The |
|
|
||
| The [`verifier`](/internal/verifier/) package provides functionality for verifying an input | ||
| provenance file. The provenance file should follow the | ||
| [Amber provenance](./../pkg/amber/schema/v1/provenance.json) format and provide a list of materials |
cmd/verifier/README.md
Outdated
|
|
||
| To verify a SLSA provenance of the Amber build type run: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Nice. I did not know about the console style.
rbehjati
force-pushed
the
remove-builder
branch
from
6e3f3a7
to
30f54d0
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #145
Removing the builder, now that it is migrated to the SLSA Framework repo.