Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Remove the Amber provenance format #225

Merged
merged 6 commits into from
Apr 21, 2023
Merged

Remove the Amber provenance format #225

merged 6 commits into from
Apr 21, 2023

Conversation

rbehjati
Copy link
Contributor

@rbehjati rbehjati commented Apr 20, 2023 •
edited
Loading

Fixes #224

  • Removes Amber provenance files and format
  • Removes BuildConfig and its related functionality (remaining from the builder that was removed in Remove builder #223)
  • Removes the ReproducibleProvenanceVerifier
  • Updates tests, and testdata files to slsa-v0.2 format; essentially removing some reference values that should be reintroduced later, once we have support for SLSA v1.0

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@rbehjati rbehjati force-pushed the remove-amber branch 4 times, most recently from 9ccd32f to ae96fb7 Compare April 20, 2023 17:30
@rbehjati rbehjati force-pushed the remove-amber branch 4 times, most recently from 50a63bf to 467b616 Compare April 21, 2023 09:05
tiziano88
tiziano88 approved these changes Apr 21, 2023
View reviewed changes
testdata/slsa_v02_provenance.json Outdated
@@ -12,20 +12,20 @@
"predicate": {
"builder": {
"id": "https://github.com/slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@refs/tags/v1.2.0"
},
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) the indentation seems incorrect now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this. Fixed.

rbehjati
rbehjati commented Apr 21, 2023
View reviewed changes
Copy link
Contributor Author

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review :)

testdata/slsa_v02_provenance.json Outdated
@@ -12,20 +12,20 @@
"predicate": {
"builder": {
"id": "https://github.com/slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@refs/tags/v1.2.0"
},
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this. Fixed.

@rbehjati rbehjati merged commit 060a7b2 into project-oak:main Apr 21, 2023
@rbehjati rbehjati deleted the remove-amber branch April 21, 2023 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

@mariaschett mariaschett Awaiting requested review from mariaschett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Amber provenance
2 participants
@rbehjati @tiziano88