This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
Documenting some functions and methods that are difficult to understand. #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Apr 16, 2018
Atomic/atomic.py
Outdated
| @@ -118,6 +124,11 @@ def pull(self): | |||
| prevstatus = status | |||
| util.write_out("") | |||
|
|
|||
| # If for some reason the NameError or AtributeError class appears in the path, | |||
| # the exception is thrown to ignore the "pass" problem. | |||
| # The NameError class handles only unqualified names while AtributeError, | |||
There was a problem hiding this comment.
s|AtributeError|AttributeError|
There was a problem hiding this comment.
@lobocode thanks for the PR, looks good in general, just a couple of small nits.
| @@ -13,7 +13,13 @@ | |||
| from docker.errors import NotFound | |||
| from .discovery import RegistryInspect, RegistryInspectError | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I'd remove at least one if not two of these added blank lines.
Atomic/atomic.py
Outdated
| def find_repo_tag(d, Id, image_name): | ||
|
|
||
| # The image_in_repotags function fetches the name of the image inside the "repotag" repository, and if it finds, |
There was a problem hiding this comment.
suggest "if finds," to "found,"
|
I will make the considerations and add some other necessary comments. Thank's! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documenting some functions and methods that are difficult to understand. I feel that the atomic project codes lack some lines of comments to facilitate future contributions. I'm working on it.
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.