This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 138
Documenting some functions and methods that are difficult to understand. #1225
Open
scovl
wants to merge
3
commits into
projectatomic:master
Choose a base branch
from
scovl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,13 @@ | |
from docker.errors import NotFound | ||
from .discovery import RegistryInspect, RegistryInspectError | ||
|
||
|
||
|
||
def find_repo_tag(d, Id, image_name): | ||
|
||
# The image_in_repotags function fetches the name of the image inside the "repotag" repository, and if it finds, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggest "if finds," to "found," |
||
# returns the name of the image, or image list. | ||
|
||
def image_in_repotags(image_name, repotags): | ||
if image_name in repotags: | ||
return image_name | ||
|
@@ -118,6 +124,11 @@ def pull(self): | |
prevstatus = status | ||
util.write_out("") | ||
|
||
# If for some reason the NameError or AtributeError class appears in the path, | ||
# the exception is thrown to ignore the "pass" problem. | ||
# The NameError class handles only unqualified names while AtributeError, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s|AtributeError|AttributeError| |
||
# appears when an object does not support attribute references or assignments. | ||
|
||
def set_args(self, args): | ||
self.args = args | ||
try: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove at least one if not two of these added blank lines.