Skip to content

Commit

Permalink
all: fix contour-envoy-healthcheck typo
Browse files Browse the repository at this point in the history
Fixes #158

Signed-off-by: Dave Cheney <dave@cheney.net>
  • Loading branch information
davecheney committed Jul 6, 2018
1 parent b90886f commit 8edd932
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion apis/contour/v1beta1/ingressroute.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ type HealthCheck struct {
// HTTP endpoint used to perform health checks on upstream service
Path string `json:"path"`
// The value of the host header in the HTTP health check request.
// If left empty (default value), the name "contour-envoy-heathcheck"
// If left empty (default value), the name "contour-envoy-healthcheck"
// will be used.
Host string `json:"host"`
// The interval (seconds) between health checks
Expand Down
2 changes: 1 addition & 1 deletion design/ingressroute-design.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ spec:
weight: 50
healthCheck (Optional):
path: /healthz # HTTP endpoint used to perform health checks on upstream service (e.g. /healthz). It expects a 200 response if the host is healthy. The upstream host can return 503 if it wants to immediately notify downstream hosts to no longer forward traffic to it.
host: "contour-envoy-heathcheck" # The value of the host header in the HTTP health check request. If left empty (default value), the name "contour-envoy-heathcheck" will be used.
host: "contour-envoy-healthcheck" # The value of the host header in the HTTP health check request. If left empty (default value), the name "contour-envoy-healthcheck" will be used.
intervalSeconds: 30 # The interval (seconds) between health checks. Defaults to 5 seconds if not set.
timeoutSeconds: 60 # The time to wait (seconds) for a health check response. If the timeout is reached the health check attempt will be considered a failure. Defaults to 2 seconds if not set.
unhealthyThresholdCount: 3 # The number of unhealthy health checks required before a host is marked unhealthy. Note that for http health checking if a host responds with 503 this threshold is ignored and the host is considered unhealthy immediately. Defaults to 3 if not defined.
Expand Down
2 changes: 1 addition & 1 deletion internal/contour/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const (
hcInterval = 10 * time.Second
hcUnhealthyThreshold = 3
hcHealthyThreshold = 2
hcHost = "contour-envoy-heathcheck"
hcHost = "contour-envoy-healthcheck"
)

// ClusterCache manages the contents of the gRPC CDS cache.
Expand Down
4 changes: 2 additions & 2 deletions internal/contour/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func TestClusterVisit(t *testing.T) {
HealthChecker: &core.HealthCheck_HttpHealthCheck_{
HttpHealthCheck: &core.HealthCheck_HttpHealthCheck{
Path: "/healthy",
Host: "contour-envoy-heathcheck",
Host: "contour-envoy-healthcheck",
},
},
}},
Expand Down Expand Up @@ -322,7 +322,7 @@ func TestClusterVisit(t *testing.T) {
IntervalSeconds: 98,
UnhealthyThresholdCount: 97,
HealthyThresholdCount: 96,
Host: "foo-bar-host",
Host: "foo-bar-host",
},
}},
}},
Expand Down

0 comments on commit 8edd932

Please sign in to comment.