Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway API: Listener Route binding selector kind must match Routes compatible with Listener protocol #3529

Closed
1 of 2 tasks
sunjayBhatia opened this issue Mar 30, 2021 · 1 comment · Fixed by #4186
Closed
1 of 2 tasks
Assignees
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Mar 30, 2021

The kind field of the route binding selector has the following description:

Kind is the kind of the route resource to select.

Kind MUST correspond to kinds of routes that are compatible with the application protocol specified in the Listener’s Protocol field.

If an implementation does not support or recognize this resource type, it SHOULD set the “ResolvedRefs” condition to false for this listener with the “InvalidRoutesRef” reason.

The protocol field is defined as:

Protocol specifies the network protocol this listener expects to receive. The GatewayClass MUST apply the Hostname match appropriately for each protocol:

- For the “TLS” protocol, the Hostname match MUST be applied to the SNI server name offered by the client.
- For the “HTTP” protocol, the Hostname match MUST be applied to the host portion of the effective request URI or the :authority pseudo-header
- For the “HTTPS” protocol, the Hostname match MUST be applied at both the TLS and HTTP protocol layers.
  • Process Kind
  • Set status on Gateway

See: https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.Listener

@sunjayBhatia sunjayBhatia added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Mar 30, 2021
stevesloka added a commit to stevesloka/contour that referenced this issue May 26, 2021
Filters the route kind by listener so that only the specified route type
will be processed by a listener.

Fixes projectcontour#3529

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue May 26, 2021
Filters the route kind by listener so that only the specified route type
will be processed by a listener.

Updates projectcontour#3529

Signed-off-by: Steve Sloka <slokas@vmware.com>
danehans pushed a commit that referenced this issue May 27, 2021
Filters the route kind by listener so that only the specified route type
will be processed by a listener.

Updates #3529

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka
Copy link
Member

The remaining bit here is to set status on Gateway.

@skriss skriss added the area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. label Oct 8, 2021
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Nov 5, 2021
@skriss skriss self-assigned this Nov 5, 2021
@skriss skriss added this to the 1.20.0 milestone Nov 5, 2021
skriss added a commit to skriss/contour that referenced this issue Nov 8, 2021
Sets a Listener condition of "ResolvedRefs: false" with
a reason of "InvalidRouteKinds" when a Listener has an
invalid allowed route in its spec.

Closes projectcontour#3529.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 8, 2021
Sets a Listener condition of "ResolvedRefs: false" with
a reason of "InvalidRouteKinds" when a Listener has an
invalid allowed route in its spec.

Closes projectcontour#3529.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 15, 2021
Sets a Listener condition of "ResolvedRefs: false" with
a reason of "InvalidRouteKinds" when a Listener has an
invalid allowed route in its spec.

Closes projectcontour#3529.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 16, 2021
Sets a Listener condition of "ResolvedRefs: false" with
a reason of "InvalidRouteKinds" when a Listener has an
invalid allowed route in its spec.

Closes projectcontour#3529.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 17, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes projectcontour#3529.
Closes projectcontour#4180.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 17, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes projectcontour#3529.
Closes projectcontour#4180.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 17, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes projectcontour#3529.
Closes projectcontour#4180.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 17, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes projectcontour#3529.
Closes projectcontour#4180.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 17, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes projectcontour#3529.
Closes projectcontour#4180.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 30, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes projectcontour#3529.
Closes projectcontour#4180.
Updates projectcontour#4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Nov 30, 2021
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.

Closes #3529.
Closes #4180.
Closes #4124.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
3 participants