internal/dag: set Gateway Listener conditions #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
requested review from
sunjayBhatia and
youngnick
and removed request for
a team
skriss
added
release-note/small
|
Using the "hide whitespace" option on the diff will help a lot here. I think there are probably still some additional situations for which we should be setting Listener conditions, but this set covered what seemed like the biggest ones / what we were already checking for in the processor logic. Any additional ones can be tacked on individually now that the scaffolding is there. |
Codecov Report
@@ Coverage Diff @@
## main #4186 +/- ##
==========================================
+ Coverage 76.09% 76.41% +0.32%
==========================================
Files 111 111
Lines 9763 9883 +120
==========================================
+ Hits 7429 7552 +123
+ Misses 2168 2164 -4
- Partials 166 167 +1
|
sunjayBhatia
approved these changes
Nov 17, 2021
Good call, added a simple unit test for that method. |
Sets various Listener conditions according to the Gateway API v1alpha2 spec. Also sets the Gateway "Ready" condition to false if there are invalid listeners. Closes projectcontour#3529. Closes projectcontour#4180. Updates projectcontour#4124. Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
gw-listener-conditions
branch
from
52d27a3 to
fe1863b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets various Listener conditions according to
the Gateway API v1alpha2 spec. Also sets the
Gateway "Ready" condition to false if there
are invalid listeners.
Closes #3529.
Closes #4180.
Closes #4124.
Signed-off-by: Steve Kriss krisss@vmware.com