Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default status for HTTPProxy resources #4132

Closed
stevesloka opened this issue Oct 24, 2021 · 0 comments · Fixed by #4133
Closed

Default status for HTTPProxy resources #4132

stevesloka opened this issue Oct 24, 2021 · 0 comments · Fixed by #4133
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@stevesloka
Copy link
Member

When a new HTTPProxy is created, if Contour isn't yet running or functioning properly, then no status is set on the resource.

We should setup kubebuilder defaults to set the initial status to be status: "Unknown", reason:"NotReconciled", message:"Waiting for controller" for all HTTPProxy resources when created.
@stevesloka stevesloka added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Oct 24, 2021
stevesloka added a commit to stevesloka/contour that referenced this issue Oct 24, 2021
@stevesloka
api: Set default status for HTTPProxy resources
7615a12 
When a new HTTPProxy is created, if Contour isn't yet running or
functioning properly, then no status is set on the resource.

This sets a default status of "NotReconciled/Waiting for controller"
on any new resource until an instance of Contour accecpts the
resource and updates the status.

Fixes projectcontour#4132

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Oct 24, 2021
Merged
@xaleeks xaleeks modified the milestone: 1.19.1 Oct 25, 2021
stevesloka added a commit that referenced this issue Oct 25, 2021
@stevesloka
api: Set default status for HTTPProxy resources (#4133)
31a5c6a 
When a new HTTPProxy is created, if Contour isn't yet running or
functioning properly, then no status is set on the resource.

This sets a default status of "NotReconciled/Waiting for controller"
on any new resource until an instance of Contour accecpts the
resource and updates the status.

Fixes #4132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: Set default status for HTTPProxy resources stevesloka/contour
2 participants
@stevesloka @xaleeks