api: Set default status for HTTPProxy resources #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new HTTPProxy is created, if Contour isn't yet running or functioning properly, then no status is set on the resource. This sets a default status of "NotReconciled/Waiting for controller" on any new resource until an instance of Contour accecpts the resource and updates the status. Fixes projectcontour#4132 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
added
the
release-note/minor
stevesloka
requested review from
skriss and
sunjayBhatia
and removed request for
a team
Signed-off-by: Steve Sloka <slokas@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4133 +/- ##
=======================================
Coverage 74.63% 74.63%
=======================================
Files 112 112
Lines 9709 9709
=======================================
Hits 7246 7246
Misses 2307 2307
Partials 156 156 |
skriss
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
👍 I think this is helpful. Eventually we probably want to add a default Condition as well (and then update it from Contour code once the proxy has been reconciled) but given that these fields are the ones that are actually shown in kubectl get right now, this makes sense initially.
sunjayBhatia
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new HTTPProxy is created, if Contour isn't yet running or
functioning properly, then no status is set on the resource.
This sets a default status of "NotReconciled/Waiting for controller"
on any new resource until an instance of Contour accecpts the
resource and updates the status.
Fixes #4132
Signed-off-by: Steve Sloka slokas@vmware.com