Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop internal/workgroup package #4206

Closed
skriss opened this issue Dec 1, 2021 · 1 comment · Fixed by #4818
Closed

drop internal/workgroup package #4206

skriss opened this issue Dec 1, 2021 · 1 comment · Fixed by #4818
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. Hacktoberfest Denotes an issue ready for any "Hacktoberfest" contributor. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@skriss
Copy link
Member

skriss commented Dec 1, 2021

looks like we could almost drop the workgroup package entirely, but it's still used in the featuretests framework. We could do the work to fully drop it in a separate PR.

Originally posted by @skriss in #4202 (comment)

#4202 (comment)

@skriss skriss added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Dec 1, 2021
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2021
@skriss skriss removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@skriss skriss added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Oct 11, 2022
@pnbrown pnbrown added the Hacktoberfest Denotes an issue ready for any "Hacktoberfest" contributor. label Oct 11, 2022
@skriss
Copy link
Member Author

skriss commented Oct 17, 2022

Throwing this into 1.24, nice small cleanup item.

@skriss skriss added this to the 1.24.0 milestone Oct 17, 2022
@skriss skriss added this to Contour Oct 17, 2022
@skriss skriss moved this to Todo in Contour Oct 17, 2022
skriss added a commit to skriss/contour that referenced this issue Oct 24, 2022
This package is no longer needed since
Contour has switched to using
controller-runtime Runnables for goroutine
management.

Closes projectcontour#4206.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Oct 24, 2022
This package is no longer needed since
Contour has switched to using
controller-runtime Runnables for goroutine
management.

Closes projectcontour#4206.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss moved this from Todo to In Progress in Contour Oct 24, 2022
@skriss skriss self-assigned this Oct 24, 2022
skriss added a commit that referenced this issue Oct 24, 2022
This package is no longer needed since
Contour has switched to using
controller-runtime Runnables for goroutine
management.

Closes #4206.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Repository owner moved this from In Progress to Done in Contour Oct 24, 2022
moeyui1 pushed a commit to moeyui1/contour that referenced this issue Oct 26, 2022
This package is no longer needed since
Contour has switched to using
controller-runtime Runnables for goroutine
management.

Closes projectcontour#4206.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. Hacktoberfest Denotes an issue ready for any "Hacktoberfest" contributor. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants