Fix workgroup AddContext bug

[chattarajoy]

In case functions are added to workgroup using AddContext method, the AddContext method doesn't exit if the corresponding function exits. This change makes sure the Run flow exits in case the function running has exited.

[codecov]

Codecov Report

Merging #4783 (e4f85a6) into main (aa741b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4783   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files         140      140           
  Lines       16859    16861    +2     
=======================================
+ Hits        12820    12822    +2     
  Misses       3787     3787           
  Partials      252      252           

Impacted Files	Coverage Δ
internal/workgroup/group.go	100.00% <100.00%> (ø)

[skriss]

Thanks for the PR @chattarajoy, however what I would really like to do is drop the workgroup package entirely since it's only being used by test code at this point and I don't think we need our own custom goroutine manager anymore -- see #4206. Would you be interested in taking that work on?

[sunjayBhatia]

yep agreed, we should focus on possibly removing the package since it's only used in tests

[chattarajoy]

Hi @skriss , since I was using this module in my own project (copied the code, not importing using go mod) I found this bug and fixed it in my project as well as thought of raising a fix here. I am sorry I won't be able to pick up the deletion of this model and remove its usage.

[skriss]

Hi @skriss , since I was using this module in my own project (copied the code, not importing using go mod) I found this bug and fixed it in my project as well as thought of raising a fix here. I am sorry I won't be able to pick up the deletion of this model and remove its usage.

@chattarajoy fair enough - I think we can merge this as-is and still look to do #4206 subsequently.