Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust Gateway API conformance test runs #4513

Closed
skriss opened this issue May 4, 2022 · 2 comments · Fixed by #4581
Closed

adjust Gateway API conformance test runs #4513

skriss opened this issue May 4, 2022 · 2 comments · Fixed by #4581
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. area/testing Issues or PRs related to tests or testing tools. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Milestone
1.22.0

Comments

@skriss
Copy link
Member

skriss commented May 4, 2022

Right now we're always running the latest and greatest Gateway API conformance tests. As @sunjayBhatia rightly pointed out, this could be problematic since it's a moving target. I propose we do the following:

  • change the PR build run to run against the conformance tests in the version of Gateway API that we use (via go.mod)*
  • add a daily build that runs the latest/greatest conformance tests, so we can stay up-to-date and fix any issues as they arise

*the caveat is that there aren't any conformance tests in the release-0.4 branch, so we'll have to wait until 0.5 to move to this.
@skriss skriss added area/testing Issues or PRs related to tests or testing tools. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 4, 2022
@skriss skriss added this to the 1.22.0 milestone May 4, 2022
@skriss skriss self-assigned this May 4, 2022
@sunjayBhatia
Copy link
Member

sounds like a nice compromise 👍🏽

@skriss
Copy link
Member Author

skriss commented Jun 8, 2022

Blocked by #4560.

skriss added a commit to skriss/contour that referenced this issue Jun 15, 2022
@skriss
Gateway API: adjust conformance runs
1035c71 
Changes the PR/push run of Gateway API
conformance to run using the go.mod
version of Gateway API, and adds a daily
run of the latest conformance tests.

Closes projectcontour#4513.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Jun 15, 2022
Merged
skriss added a commit to skriss/contour that referenced this issue Jun 15, 2022
@skriss
Gateway API: adjust conformance runs
1860fbb 
Changes the PR/push run of Gateway API
conformance to run using the go.mod
version of Gateway API, and adds a daily
run of the latest conformance tests.

Closes projectcontour#4513.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jun 15, 2022
@skriss
Gateway API: adjust conformance runs
9c8af69 
Changes the PR/push run of Gateway API
conformance to run using the go.mod
version of Gateway API, and adds a daily
run of the latest conformance tests.

Closes projectcontour#4513.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jun 16, 2022
@skriss
Gateway API: adjust conformance runs
73ed6c5 
Changes the PR/push run of Gateway API
conformance to run using the go.mod
version of Gateway API, and adds a daily
run of the latest conformance tests.

Closes projectcontour#4513.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jun 16, 2022
@skriss
Gateway API: adjust conformance runs
69a5b9c 
Changes the PR/push run of Gateway API
conformance to run using the go.mod
version of Gateway API, and adds a daily
run of the latest conformance tests.

Closes projectcontour#4513.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Jun 16, 2022
@skriss
Gateway API: adjust conformance runs (#4581)
45ff8f7 
Changes the PR/push run of Gateway API
conformance to run using the go.mod
version of Gateway API, and adds a daily
run of the latest conformance tests.

Closes #4513.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. area/testing Issues or PRs related to tests or testing tools. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Gateway API: adjust conformance runs skriss/contour
2 participants
@skriss @sunjayBhatia