Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run Gateway API conformance tests #4452

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Apr 6, 2022

Closes #4429.

Signed-off-by: Steve Kriss krisss@vmware.com

Closes projectcontour#4429.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner April 6, 2022 16:46
@skriss skriss requested review from stevesloka, youngnick and sunjayBhatia and removed request for a team April 6, 2022 16:46
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #4452 (c7f8f0a) into main (6add750) will not change coverage.
The diff coverage is n/a.

❗ Current head c7f8f0a differs from pull request most recent head 43e0d52. Consider uploading reports for the commit 43e0d52 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4452   +/-   ##
=======================================
  Coverage   73.67%   73.67%           
=======================================
  Files         137      137           
  Lines       12332    12332           
=======================================
  Hits         9085     9085           
  Misses       3049     3049           
  Partials      198      198           

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Apr 6, 2022
EOF

cd $(mktemp -d)
git clone https://github.com/kubernetes-sigs/gateway-api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth pinning to a specific sha?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was to let them track HEAD since the upstream tests are very much a WIP (there are only ~6 right now, many more planned to be added), so we keep up with the latest automatically, but it does have the downside that they could start failing at any moment. I was planning to leave them as not required so they wouldn't block PRs in that case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can always circle back here and revise if the current approach becomes too noisy, or once the tests stabilize.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙🏽

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

@skriss skriss merged commit eb6cae4 into projectcontour:main Apr 6, 2022
@skriss skriss deleted the gw-conformance branch April 6, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run Gateway API conformance tests as part of CI
2 participants