-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run Gateway API conformance tests #4452
Conversation
Closes projectcontour#4429. Signed-off-by: Steve Kriss <krisss@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4452 +/- ##
=======================================
Coverage 73.67% 73.67%
=======================================
Files 137 137
Lines 12332 12332
=======================================
Hits 9085 9085
Misses 3049 3049
Partials 198 198 |
EOF | ||
|
||
cd $(mktemp -d) | ||
git clone https://github.com/kubernetes-sigs/gateway-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth pinning to a specific sha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was to let them track HEAD
since the upstream tests are very much a WIP (there are only ~6 right now, many more planned to be added), so we keep up with the latest automatically, but it does have the downside that they could start failing at any moment. I was planning to leave them as not required so they wouldn't block PRs in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can always circle back here and revise if the current approach becomes too noisy, or once the tests stabilize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤙🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment
Closes #4429.
Signed-off-by: Steve Kriss krisss@vmware.com