Make status test readable

[youngnick]

This PR attempts to make the status tests more readable by putting the
fixtures next to the test cases they are used in as much as possible.

• Extracted the common Service and Secret fixtures (and the certificates) to internal/fixtures.
• Names are also changed. No more proxy47a!
• I also found some duplicate tests (probably from when we converted IngressRoute tests to HTTPProxy ones).

Blocks #2495 until it's merged; I don't want to attempt refactoring all these tests until it's a bit
easier to see what everything's used for.

Signed-off-by: Nick Young ynick@vmware.com

[codecov]

Codecov Report

Merging #2940 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2940   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          87       87           
  Lines        5604     5604           
=======================================
  Hits         4198     4198           
  Misses       1315     1315           
  Partials       91       91           

[jpeach]

The main things here are that we should establish a consistent naming convention for fixture globals, and use a local run helper in the status tests. I haven't reviewed the test coverage in detail; the coverage percentage is unchanged, which is great, but we may want to ensure that we didn't drop important test cases.

[skriss]

couple nits so far; will look through status_test.go in some more detail.

[skriss]

Other than the nits I'm happy with this, it's definitely an improvement in readability. I agree with James' comment that we may want to do a detailed tick and tie to ensure we didn't inadvertently drop any important test cases, but I haven't done that.

[youngnick]

I only knowingly removed two test cases, that I checked carefully to ensure that were duplicates. I'll use the "show coverage" thing on main and here and check if I've dropped anything.

I'll also swap over to the run style rather than table style; that's not a huge change now the hard part (moving everything) is done.

[youngnick]

I've gone over all of the places in httpproxy_processor.go that are not covered in this branch and main, and confirmed that they match. I've also got a list which will be handy of what we're not covering.

[youngnick]

Only test failure is the SNI flake, I'm going to go ahead and merge this so I can bring it in to the other status work.