Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make status test readable #2940

Merged
merged 7 commits into from
Sep 25, 2020
Merged

Make status test readable #2940

merged 7 commits into from
Sep 25, 2020

Commits on Sep 25, 2020

  1. internal/dag: Make status_test.go more readabale 

    - Extract status Secret and Service fixtures out to `internal/fixture`, assuming they could be reused.

Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    5859573 View commit details
    Browse the repository at this point in the history

  2. - Extract certificates out to internal/fixture 

    Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    5f0c8a5 View commit details
    Browse the repository at this point in the history

  3. internal/dag: Make status_test.go more readable 

    This commit attempts to make the status tests more readable by putting the
fixtures next to the test cases they are used in as much as possible.

Names are also changed. No more `proxy47a`!

I also found some duplicate tests (probably from when we converted
IngressRoute tests to HTTPProxy ones).

Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    5ed3ee0 View commit details
    Browse the repository at this point in the history

  4. Turns out Go 1.14 and Go 1.15 do something different?! 

    Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    2aa688a View commit details
    Browse the repository at this point in the history

  5. Fix naming of fixtures per PR comments 

    Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    cdd05cc View commit details
    Browse the repository at this point in the history

  6. Update status_test.go to local run function 

    Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    dced892 View commit details
    Browse the repository at this point in the history

  7. Final pass to clean up comemnts and descriptions 

    Signed-off-by: Nick Young <ynick@vmware.com>
    Nick Young committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    b7f381a View commit details
    Browse the repository at this point in the history