Allow wildcard fqdn's for HTTPProxy resources #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes projectcontour#1228 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
added
the
release-note/small
stevesloka
requested review from
tsaarni and
youngnick
and removed request for
a team
Signed-off-by: Steve Sloka <slokas@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4145 +/- ##
==========================================
- Coverage 74.64% 72.95% -1.69%
==========================================
Files 112 115 +3
Lines 9722 10096 +374
==========================================
+ Hits 7257 7366 +109
- Misses 2309 2574 +265
Partials 156 156
|
Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
wildcardHTTPProxy
branch
from
10ec51f to
4fb69a9
Compare
Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
wildcardHTTPProxy
branch
from
32789c5 to
902e787
Compare
youngnick
approved these changes
Oct 31, 2021
|
#4147 might be a fix to the test flakes here |
sunjayBhatia
approved these changes
Nov 1, 2021
internal/dag/httpproxy_processor.go
Outdated
| // as Envoy's virtualhost hostname wildcard matching can match multiple | ||
| // labels. This match ignores a port in the hostname in case it is present. | ||
| if strings.HasPrefix(rootProxy.Spec.VirtualHost.Fqdn, "*.") { | ||
| r.HeaderMatchConditions = []HeaderMatchCondition{ |
There was a problem hiding this comment.
i think maybe only change I would make is to pull this out into a helper now its used in a few places, so we get something like:
if strings.HasPrefix(rootProxy.Spec.VirtualHost.Fqdn, "*.") {
r.HeaderMatchConditions = append(r.HeaderMatchConditions, wildcardDomainHeaderMatch(rootProxy.Spec.VirtualHost.Fqdn))
}Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
That still may help, but what I found was I think there was a timing issue since many of our tests use |
skriss
added a commit
to skriss/contour-operator
that referenced
this pull request
Nov 1, 2021
Updates operator per Contour changes: projectcontour/contour#4141 projectcontour/contour#4138 projectcontour/contour#4145 Signed-off-by: Steve Kriss <krisss@vmware.com>
stevesloka
pushed a commit
to projectcontour/contour-operator
that referenced
this pull request
Nov 2, 2021
Updates operator per Contour changes: projectcontour/contour#4141 projectcontour/contour#4138 projectcontour/contour#4145 Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1228
Signed-off-by: Steve Sloka slokas@vmware.com