test/e2e: Fix possible cause of flakes in cookie rewrite test #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names of resources and FQDN in HTTPProxies were the same across tests, possible causing some test flakes in CI where globally set cookies were not rewritten. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
requested review from
tsaarni and
youngnick
and removed request for
a team
sunjayBhatia
added
the
release-note/none-required
Codecov Report
@@ Coverage Diff @@
## main #4147 +/- ##
==========================================
+ Coverage 74.69% 74.70% +0.01%
==========================================
Files 112 112
Lines 9736 9736
==========================================
+ Hits 7272 7273 +1
+ Misses 2308 2307 -1
Partials 156 156
|
skriss
approved these changes
Nov 1, 2021
stevesloka
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names of resources and FQDN in HTTPProxies were the same across tests,
possible causing some test flakes in CI where globally set cookies were
not rewritten.