hack/release: Remove ttlSecondsAfterFinished from certgen job #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrewega
requested review from
stevesloka and
sunjayBhatia
and removed request for
a team
|
cc @stevesloka @youngnick as discussed on Slack a few hours ago I did some very minor testing ( |
lrewega
force-pushed
the
lrewega/release-rm-certgen-job-ttl
branch
from
f0239c1 to
ea2aed4
Compare
Codecov Report
@@ Coverage Diff @@
## main #4200 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 111 111
Lines 9883 9883
=======================================
Hits 7552 7552
Misses 2164 2164
Partials 167 167 |
sunjayBhatia
added
the
release-note/small
|
@lrewega could you please add a release note following the process here: https://github.com/projectcontour/contour/blob/main/CONTRIBUTING.md#commit-message-and-pr-guidelines (labeled this as a "small" change) thanks! |
lrewega
force-pushed
the
lrewega/release-rm-certgen-job-ttl
branch
2 times, most recently
from
72c2962 to
f49c5cf
Compare
|
Just the codespell issue to fix, then this LGTM. Nice work @lrewega, thanks. |
lrewega
force-pushed
the
lrewega/release-rm-certgen-job-ttl
branch
2 times, most recently
from
18a0874 to
ab39d14
Compare
youngnick
approved these changes
Dec 1, 2021
The certgen job is versioned in releases, so deleting it should not be necessary for most consumers. Deleting the job can cause problems when applying the quickstart config via continous deployment (e.g. Argo CD) as the job disappears before an external observer can acknowledge it completed successfully, or even confirm that it ever existed. Signed-off-by: Luke Rewega <lrewega@buf.build>
lrewega
force-pushed
the
lrewega/release-rm-certgen-job-ttl
branch
from
a7f8597 to
ee80483
Compare
skriss
approved these changes
Dec 1, 2021
sunjayBhatia
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The certgen job is versioned in releases, so deleting it should not be
necessary for most consumers. Deleting the job can cause problems when
applying the quickstart config via continous deployment (e.g. Argo CD)
as the job disappears before an external observer can acknowledge it
completed successfully, or even confirm that it ever existed.
Signed-off-by: Luke Rewega lrewega@buf.build