Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/release: Remove ttlSecondsAfterFinished from certgen job #4200

Merged
merged 1 commit into from
Dec 1, 2021
Merged

hack/release: Remove ttlSecondsAfterFinished from certgen job #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/4200-lrewega-small.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removes spec.ttlSecondsAfterFinished from certgen job in versioned releases, as immediately deleting it upon completion will not be useful for most consumers.
8 changes: 8 additions & 0 deletions hack/release/make-release-tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ for example in examples/contour/02-job-certgen.yaml ; do
"$example"
done

# Remove spec.ttlSecondsAfterFinished from the certgen job, as it is versioned
# for releases and doesn't need to be cleaned up.
for example in examples/contour/02-job-certgen.yaml ; do
run::sed \
'-e/^[[:blank:]]*ttlSecondsAfterFinished:/d' \
"$example"
done

make generate

# If pushing the tag failed, then we might have already committed the
Expand Down