Update to Fluent Syntax 0.9 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stasm - it's a pretty small change, follows closely the spec changes and passes all the fixtures, so I hope it'll be a skim rather than any deep review :) |
zbraniecki
force-pushed
the
zeronine
branch
2 times, most recently
from
319eb21 to
c45dcd5
Compare
Merged
stasm
approved these changes
Feb 21, 2019
| { | ||
| let mut map = serializer.serialize_map(Some(3))?; | ||
| map.serialize_entry("type", "NumberLiteral")?; | ||
| //map.serialize_entry("raw", raw)?; |
There was a problem hiding this comment.
Thanks for implementing a work-around for this. You may want to wait for projectfluent/fluent#242 to land and uncomment this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a port of the changes to the syntax.