Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to NumberLiteral from #232 #242

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Feb 21, 2019

Fix #239. Revert changes from #232 which made value be a float, and added precision. Also rename value to raw for consistency with StringLiteral. I'll file another issue to discuss removing unescaping from the AST and moving it into the resolver.

@stasm
Copy link
Contributor Author

stasm commented Feb 22, 2019

@Pike, I'd like to land this separately from #243 to record the reverting of #232 explicitly in the history. To reduce the diff, perhaps I should drop the "rename value to raw" part, since we know that we'll change it anyways in #243?

@Pike
Copy link
Contributor

Pike commented Feb 22, 2019

Yeah, that might help, but would that make rebasing #246 hard?

@stasm stasm changed the title Revert changes to NumberLiteral and rename value to raw Revert changes to NumberLiteral from #232 Feb 24, 2019
@stasm
Copy link
Contributor Author

stasm commented Feb 24, 2019

I intended to rebase/squash #246 anyways, and it wasn't hard at all :)

@stasm
Copy link
Contributor Author

stasm commented Feb 24, 2019

I've updated this PR and I've renamed NumberLiteral.raw back to value, just as it was called before #232. This PR isn't a strict revert, however. I've simplified the NumberLiteral grammar production and I've kept the test which I had added in #235.

@stasm stasm merged commit 9d8daf1 into projectfluent:master Feb 26, 2019
@stasm stasm deleted the number-literal branch February 26, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store number values as strings of digits
2 participants