This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
[Coordinated] Serialize messages as liiklus CloudEvents #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbottard
force-pushed
the
cloud-events
branch
from
5e39945
to
5dc2170
Compare
fbiville
reviewed
Feb 26, 2020
| .setData(next.getPayload()) | ||
| .setDataContentType(next.getContentType()) | ||
| .setType("riff-event") // TODO | ||
| .setSource(this.group) // TODO |
There was a problem hiding this comment.
TODO for another PR or sth to figure out now?
There was a problem hiding this comment.
Later, needs to figure out even the meaning we want to give this.
The whole PR is ready for review as-is, but what you see is what you get
sbawaska
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.