[Coordinated, template] Use CloudEvent aware modules. #313
Conversation
config/riff-streaming.yaml
Outdated
| @@ -6567,7 +6567,7 @@ subjects: | |||
| --- | |||
| apiVersion: v1 | |||
| data: | |||
| gatewayImage: bsideup/liiklus:0.9.0 | |||
| gatewayImage: ctr.run/github.com/bsideup/liiklus:00385b688bc34d6fdbe2b5eeb39daa26e09f8b02 | |||
There was a problem hiding this comment.
Or wait for bsideup/liiklus#252 to be merged and use a released version
There was a problem hiding this comment.
you can now use bsideup/liiklus:0.10.0-rc1
There was a problem hiding this comment.
Let's kill two birds with one stone once the streaming-processor PR is merged as well...
config/riff-streaming.yaml
Outdated
| @@ -6589,7 +6589,7 @@ metadata: | |||
| --- | |||
| apiVersion: v1 | |||
| data: | |||
| processorImage: projectriff/streaming-processor-native:1.0.0-SNAPSHOT-20191223112938-672714499ed0c511@sha256:41ad7b6b350370b5e53cc718eb7cde49d7f9f7e22e33a3204ae0a4158f798819 | |||
| processorImage: ericbottard/processor-native@sha256:9e1a16a68bd58e61c34e6bfc0af4c25fbd3f04fa2a045f0cd156c0ed71c8a641 | |||
There was a problem hiding this comment.
Or wait for projectriff/streaming-processor#42 to be merged
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 58.28% 58.28%
=======================================
Files 73 73
Lines 3917 3917
=======================================
Hits 2283 2283
Misses 1592 1592
Partials 42 42Continue to review full report at Codecov.
|
|
@ericbottard is this in scope for 0.5? |
I would say no, although not really for me to decide. Also depends on the state of the liiklus PR. I would rather have us depend on a released version of liiklus for our releases. |
|
@ericbottard not sure when 0.5 is planned but I am hoping to merge the CloudEvents PR this week. It is nearly done implementation wise, just need to finish the extensions (have it working but a bit concerned about the APIs used) |
ericbottard
force-pushed
the
cloud-events
branch
from
c9a5abb
to
c038a5d
Compare
ericbottard
force-pushed
the
cloud-events
branch
from
c038a5d
to
5708ddf
Compare
|
superceded by #333 |
This PR uses temporary coordinates, showcases where edits will be needed.