Add support for replacing outdated CSI holder pods #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
simu
force-pushed
the
feat/restart-holder-ds
branch
6 times, most recently
from
bc9534d
to
385c133
Compare
DebakelOrakel
approved these changes
Feb 23, 2024
We check the holder pod's `metadata.labels.pod-template-generation` against the DaemonSet's `metadata.generation` to identify outdated pods. The script waits until the node is drained by waiting until no non-daemonset pods are running and then deletes all holder pods on the node if any were identified as outdated.
Apparently the value of that label isn't allowed to contain `:` even though `:` is a valid character for `ClusterRole` and `ClusterRoleBinding` resources.
simu
force-pushed
the
feat/restart-holder-ds
branch
from
385c133
to
7ef7cf3
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check the holder pod's
metadata.labels.pod-template-generationagainst the DaemonSet'smetadata.generationto identify outdated pods.The script waits until the node is drained by waiting until no non-daemonset pods are running and then deletes all holder pods on the node if any were identified as outdated.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.