Ignore kubectl error output when extracting current holder pod generation
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration This suppresses error messages like the following on installations which only have cephfs or rbd enabled, but not both. ``` Error from server (NotFound): daemonsets.apps "csi-rbdplugin-holder-cluster" not found ```
DebakelOrakel
approved these changes
Feb 27, 2024
simu
force-pushed
the
fix/restart-holder-suppress-error
branch
from
6bb2e3f
to
9dbd393
Compare
We add the script's md5sum as an annotation to the DaemonSet pod template to force Kubernetes to recreate the pods when we modify the script. Additionally, we set `sync-wave=10` for the DaemonSet to ensure that the ConfigMap changes are synced before the checksum annotation on the DaemonSet is updated.
simu
force-pushed
the
fix/restart-holder-suppress-error
branch
from
9dbd393
to
f4b5147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suppresses error messages like the following on installations which only have cephfs or rbd enabled, but not both.
We don't care about the resulting value of the generation variable when the daemonset is missing, since we'll check an empty pod list for outdated pods in that case.
Additionally, we ensure that the holder-update DaemonSet pods are restarted when we modify the script by adding the script's md5sum as an annotation in the pod template.
Follow-up for #154
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.