-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to control Go metrics in the default collector. #1089
Comments
It is indeed unfortunate we cannot change the default registry Go collector to new metrics as registering another GoCollector would register base metrics. It's relatively easy to change it, but not sure it's worth it. We generally want to deprecate global registry (my opinion).
You are right that some filtering might be amazing. Perhaps it could solve GoCollector on the default register. I think it's worth considering. Open Questions
|
I all I really want to do is be able to toggle or update the filter on the GoCollector. |
Fixes: #1089 Signed-off-by: bwplotka <bwplotka@gmail.com>
Fixes: #1089 Signed-off-by: bwplotka <bwplotka@gmail.com>
Fixes: #1089 Signed-off-by: bwplotka <bwplotka@gmail.com>
…uration. (#1102) * goCollector: Added rule support for granular metric configuration. Fixes: #1089 Signed-off-by: bwplotka <bwplotka@gmail.com> * Added compatibility mode with old options. (#1107) * Added compatibility mode with old options. Signed-off-by: bwplotka <bwplotka@gmail.com> * Copyright header. Signed-off-by: bwplotka <bwplotka@gmail.com> * Remove bucket option for now. (#1108) Signed-off-by: bwplotka <bwplotka@gmail.com> * collectors/GoCollector: Add tests and examples (#1109) * Add tests and examples Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add docs for the presets Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
…uration. (#1102) * goCollector: Added rule support for granular metric configuration. Fixes: prometheus/client_golang#1089 Signed-off-by: bwplotka <bwplotka@gmail.com> * Added compatibility mode with old options. (#1107) * Added compatibility mode with old options. Signed-off-by: bwplotka <bwplotka@gmail.com> * Copyright header. Signed-off-by: bwplotka <bwplotka@gmail.com> * Remove bucket option for now. (#1108) Signed-off-by: bwplotka <bwplotka@gmail.com> * collectors/GoCollector: Add tests and examples (#1109) * Add tests and examples Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add docs for the presets Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
With client_golang v1.12.2, we removed the
runtime/metrics
from the default collector.But now it seems difficult to get these metrics back without having to abandon the default registry. This makes the use of
promauto
more cumbersome.Some ideas:
runtime/metrics
are included.For example, of the new metrics I only need
/sched/latencies:seconds
right now.The text was updated successfully, but these errors were encountered: