Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility mode with old options. #1107

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Added compatibility mode with old options. #1107

merged 2 commits into from
Aug 5, 2022

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Aug 5, 2022

Signed-off-by: bwplotka bwplotka@gmail.com

@bwplotka bwplotka requested a review from kakkoyun August 5, 2022 14:50
Signed-off-by: bwplotka <bwplotka@gmail.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

The only missing thing is the licence header.

Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka bwplotka merged commit 881c608 into go-coll Aug 5, 2022
@bwplotka bwplotka deleted the comp branch August 5, 2022 15:31
kakkoyun added a commit that referenced this pull request Aug 5, 2022
…uration. (#1102)

* goCollector: Added rule support for granular metric configuration.

Fixes: #1089

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Added compatibility mode with old options. (#1107)

* Added compatibility mode with old options.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Copyright header.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Remove bucket option for now. (#1108)

Signed-off-by: bwplotka <bwplotka@gmail.com>

* collectors/GoCollector: Add tests and examples (#1109)

* Add tests and examples

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Add docs for the presets

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants